Bug 197352 – [Flatpak] webkit-build fails due to missing GTK2 in build environment

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

Just tested from a fresh repository (right after running “git clean -xdf”):

 % update-webkitgtk-flatpak
 [lots of output, build completes just fine]

 % build-webkit --gtk
 [cmake output, eventually fails with:]

 -- Checking for module 'gtk+-2.0'
 --   Package 'gtk+-2.0', required by 'virtual:world', not found
 CMake Error at /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
   Could NOT find GTK2 (missing: GTK2_INCLUDE_DIRS GTK2_LIBRARIES) (Required
   is at least version "2.24.10")
 Call Stack (most recent call first):
   /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
   Source/cmake/FindGTK2.cmake:49 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
   Source/cmake/OptionsGTK.cmake:290 (find_package)
   Source/cmake/WebKitCommon.cmake:56 (include)
   CMakeLists.txt:167 (include)

 -- Configuring incomplete, errors occurred!

[Adrian Perez]

As a workaround, once can use instead:

 % build-webkit --gtk --cmakeargs='-DENABLE_PLUGIN_PROCESS_GTK2=OFF'

but in my opinion developers should not need to pass anything special
to “build-webkit” to get a vanilla build done with the usual development
compilation options.

From what I understand, this is because the Flatpak SDK is not shipping
GTK2 anymore, which means we have two ways to go about this:

 a.) Add GTK2 to our local build manifest.
 b.) When building inside the Flatpak environment, automatically
     disable the GTK2 plugin process.

While I would prefer to to (b.) —and in the long run that is what
will happen— at the moment we support the option, and threfore I think
that we should routinely build with the option enabled to make sure
the code does not bitrot, so right now I think we should go for (a.).

[Michael Catanzaro]

That's weird, because we never had GTK2 in gnome-build-meta.

[Adrian Perez]

Created attachment 369282 [details]
Patch

[Philippe Normand]

Comment on attachment 369282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369282&action=review

> Tools/flatpak/org.webkit.GTK.yaml:101
> +  config-opts:

Can examples also be disabled?

[Adrian Perez]

(In reply to Philippe Normand from comment #4)
> Comment on attachment 369282 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369282&action=review
> 
> > Tools/flatpak/org.webkit.GTK.yaml:101
> > +  config-opts:
> 
> Can examples also be disabled?

Unfortunately, there is no flag in the autotools configure script
to disable the examples :-/

[WebKit Commit Bot]

Comment on attachment 369282 [details]
Patch

Clearing flags on attachment: 369282

Committed r245011: <https://trac.webkit.org/changeset/245011>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50542468>