Bug 197336 - Storage::deleteOldVersions does not need to retain Storage
Summary: Storage::deleteOldVersions does not need to retain Storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-26 18:07 PDT by Alex Christensen
Modified: 2019-04-30 01:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2019-04-26 18:08 PDT, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-26 18:07:25 PDT 
Storage::deleteOldVersions does not need to retain Storage
Comment 1 Alex Christensen 2019-04-26 18:08:25 PDT 
Created attachment 368373 [details]
Patch
Comment 2 Alex Christensen 2019-04-26 18:08:28 PDT 
<rdar://problem/48679972>
Comment 3 Alex Christensen 2019-04-29 13:32:59 PDT 
http://trac.webkit.org/r244750
Comment 4 Chris Dumez 2019-04-29 14:09:07 PDT 
Comment on attachment 368373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368373&action=review

> Source/WebKit/ChangeLog:5
> +        <rdar://problem/48679972>

How does this bug explain <rdar://problem/48679972> ? What's the CompletionHandler that crashes here?
Comment 5 Alex Christensen 2019-04-29 15:28:46 PDT 
rdar://problem/47759337 not rdar://problem/48679972
Comment 6 Alex Christensen 2019-04-29 15:40:24 PDT 
Hmmm, now I'm not sure.  I definitely saw the destructor of this lambda being the cause of a crash but now I can't find it.