Bug 197324 – JSWrapperMap should check if existing prototype properties are wrappers when copying exported methods.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

JSWrapperMap should only look for own properties on prototypes.

[Keith Miller]

Created attachment 368567 [details]
Patch

[Keith Miller]

Created attachment 368569 [details]
Patch

[EWS Watchlist]

Comment on attachment 368569 [details]
Patch

Attachment 368569 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12041744

New failing tests:
webaudio/oscillator-ended.html

[EWS Watchlist]

Created attachment 368577 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Saam Barati]

Comment on attachment 368569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368569&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +        property. Normally this would only happen if a Objective-C super

a => an

> Source/JavaScriptCore/ChangeLog:15
> +        Object.protype the overriden method won't be exported.

protype => prototype

> Source/JavaScriptCore/API/JSWrapperMap.mm:274
> +            bool hasProperty = jsObject->getPropertySlot(exec, JSC::Identifier::fromString(exec, String(name)), slot);

what about exceptions? Maybe you wanted VMInquiry above?

> Source/JavaScriptCore/API/tests/testapi.mm:2541
> +- (BOOL)other;

is this needed?

[Keith Miller]

Created attachment 369211 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 369211 [details]
Patch for landing

Clearing flags on attachment: 369211

Committed r244999: <https://trac.webkit.org/changeset/244999>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Keith Miller]

rdar://problem/50253144