Bug 19730 - REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
Summary: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Cameron Zwarich (cpst)
URL: http://web.ist.utl.pt/~antonio.afonso...
Keywords: HasReduction, Regression
Depends on:
Reported: 2008-06-23 12:45 PDT by Alexey Proskuryakov
Modified: 2008-06-24 02:39 PDT (History)
2 users (show)

See Also:

reduction (877 bytes, text/html)
2008-06-23 23:15 PDT, Alexey Proskuryakov
no flags Details
further reduction (417 bytes, text/html)
2008-06-23 23:48 PDT, Alexey Proskuryakov
no flags Details
Proposed patch (1.21 KB, patch)
2008-06-24 02:00 PDT, Cameron Zwarich (cpst)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2008-06-23 12:45:47 PDT
Steps to reproduce:
1. Open http://web.ist.utl.pt/~antonio.afonso/agi/
2. Press Return.

An in-game alert about "some elements of plot which may not be considered appropriate for some children" appears. It is too wide in ToT, as text is not wrapped. It is wrapped in Firefox 2 and in Safari 3.1.1
Comment 1 mitz 2008-06-23 13:25:58 PDT
Looking around a little (until the inspector hit an assertion failure) did not convince me that this was necessarily a layout bug.
Comment 2 Alexey Proskuryakov 2008-06-23 23:15:46 PDT
Created attachment 21895 [details]
Comment 3 Alexey Proskuryakov 2008-06-23 23:48:09 PDT
Created attachment 21896 [details]
further reduction
Comment 4 Cameron Zwarich (cpst) 2008-06-24 00:02:48 PDT
The codegen tells me that this is probably my fault. I am pretty sure I know how to fix it. Assigning the bug to myself.
Comment 5 Cameron Zwarich (cpst) 2008-06-24 00:47:09 PDT
This is caused by r34497. Rolling out the change by hand fixes the bug.
Comment 6 Cameron Zwarich (cpst) 2008-06-24 02:00:39 PDT
Created attachment 21899 [details]
Proposed patch

I am writing some comprehensive tests for this class of bug right now, but I'll let someone review it first.
Comment 7 Oliver Hunt 2008-06-24 02:01:57 PDT
Comment on attachment 21899 [details]
Proposed patch

r=me, once you have some testcases
Comment 8 Cameron Zwarich (cpst) 2008-06-24 02:39:20 PDT
Landed in r34758.