Bug 197299 - Trying to load a main resource outside the sandbox should not crash the WebContent process
Summary: Trying to load a main resource outside the sandbox should not crash the WebCo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-25 15:44 PDT by Chris Dumez
Modified: 2019-04-25 17:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2019-04-25 15:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-04-25 15:44:37 PDT 
Trying to load a main resource outside the sandbox should not crash the WebContent process. We should simply ignore the load and log an error message.
Comment 1 Chris Dumez 2019-04-25 15:44:54 PDT 
<rdar://problem/49808042>
Comment 2 Chris Dumez 2019-04-25 15:46:18 PDT 
Created attachment 368279 [details]
Patch
Comment 3 Geoffrey Garen 2019-04-25 16:31:32 PDT 
Comment on attachment 368279 [details]
Patch

r=me

Can we API test this?
Comment 4 Chris Dumez 2019-04-25 16:40:02 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 368279 [details]
> Patch
> 
> r=me
> 
> Can we API test this?

Last I checked, our API test runner was not sandboxed. Do you believe this has changed?
Comment 5 Chris Dumez 2019-04-25 16:40:47 PDT 
(In reply to Chris Dumez from comment #4)
> (In reply to Geoffrey Garen from comment #3)
> > Comment on attachment 368279 [details]
> > Patch
> > 
> > r=me
> > 
> > Can we API test this?
> 
> Last I checked, our API test runner was not sandboxed. Do you believe this
> has changed?

According to rdar://problem/42638129 which I filed a while back, this has not been fixed yet.
Comment 6 WebKit Commit Bot 2019-04-25 17:17:28 PDT 
Comment on attachment 368279 [details]
Patch

Clearing flags on attachment: 368279

Committed r244670: <https://trac.webkit.org/changeset/244670>
Comment 7 WebKit Commit Bot 2019-04-25 17:17:31 PDT 
All reviewed patches have been landed.  Closing bug.