Bug 197298 - webkitpy: Including skipped tests in the final count
Summary: webkitpy: Including skipped tests in the final count
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-25 15:23 PDT by Jonathan Bedard
Modified: 2019-04-25 17:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.34 KB, patch)
2019-04-25 15:55 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-04-25 15:23:35 PDT
Lucas pointed out to me that upon completion of a layout test run, we will print out a description of how many tests passed vs the total number of tests. The problem with this metric is that the total number of tests includes the tests rightfully skipped because they are not run on the specified port.
Comment 1 Jonathan Bedard 2019-04-25 15:24:05 PDT
<rdar://problem/49705424>
Comment 2 Jonathan Bedard 2019-04-25 15:55:03 PDT
Created attachment 368280 [details]
Patch
Comment 3 WebKit Commit Bot 2019-04-25 17:17:45 PDT
Comment on attachment 368280 [details]
Patch

Clearing flags on attachment: 368280

Committed r244671: <https://trac.webkit.org/changeset/244671>
Comment 4 WebKit Commit Bot 2019-04-25 17:17:46 PDT
All reviewed patches have been landed.  Closing bug.