RESOLVED FIXED 197291
Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr 
https://bugs.webkit.org/show_bug.cgi?id=197291
Summary Add WTF::findIgnoringASCIICaseWithoutLength to replace strcasestr
Don Olmstead
Reported 2019-04-25 13:33:58 PDT
Within the JSC tests strcasestr is used. This function is not available on Windows. To support compilation on Windows we should emulate strcasestr within WTF.
Attachments
Patch (7.41 KB, patch)
2019-04-25 13:37 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.41 KB, patch)
2019-04-25 13:59 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-04-25 13:37:26 PDT
Created attachment 368260 [details] Patch
Don Olmstead
Comment 2 2019-04-25 13:59:07 PDT
Created attachment 368265 [details] Patch
Konstantin Tokarev
Comment 3 2019-04-25 14:59:59 PDT
(In reply to Don Olmstead from comment #0) > Within the JSC tests strcasestr is used. This function is not available on > Windows. To support compilation on Windows we should emulate strcasestr > within WTF. It's more convenient to have such justifications right inside commit message (and changelog). When I personally make a patch which requires justification, I first write it inside git commit message and then copy it to bugzilla as a first comment
Ross Kirsling
Comment 4 2019-04-25 15:01:50 PDT
Comment on attachment 368265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368265&action=review > Source/WTF/wtf/text/StringCommon.h:469 > +inline size_t findIgnoringASCIICaseWithoutLength(const char* source, const char* matchCharacters) Looking at the other *WithoutLength functions, I wonder if `source` should have a templated type (i.e. const StringClass&)?
Konstantin Tokarev
Comment 5 2019-04-25 15:06:09 PDT
Comment on attachment 368265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368265&action=review >> Source/WTF/wtf/text/StringCommon.h:469 >> +inline size_t findIgnoringASCIICaseWithoutLength(const char* source, const char* matchCharacters) > > Looking at the other *WithoutLength functions, I wonder if `source` should have a templated type (i.e. const StringClass&)? AFAIU other *WithoutLength functions use StringClass as a placeholder of C++ string class like String or AtomicString, primitive const char* is always explicit there
Don Olmstead
Comment 6 2019-04-25 18:38:35 PDT
Comment on attachment 368265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368265&action=review >>> Source/WTF/wtf/text/StringCommon.h:469 >>> +inline size_t findIgnoringASCIICaseWithoutLength(const char* source, const char* matchCharacters) >> >> Looking at the other *WithoutLength functions, I wonder if `source` should have a templated type (i.e. const StringClass&)? > > AFAIU other *WithoutLength functions use StringClass as a placeholder of C++ string class like String or AtomicString, primitive const char* is always explicit there Also strlen needs to be called.
WebKit Commit Bot
Comment 7 2019-04-26 09:51:55 PDT
Comment on attachment 368265 [details] Patch Clearing flags on attachment: 368265 Committed r244694: <https://trac.webkit.org/changeset/244694>
WebKit Commit Bot
Comment 8 2019-04-26 09:51:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-04-26 09:52:17 PDT
<rdar://problem/50245918>
Note You need to log in before you can comment on or make changes to this bug.