[iOS] Add internal setting to force -webkit-text-size-adjust to "auto"
Created attachment 368215 [details] Patch
<rdar://problem/50211019>
Comment on attachment 368215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368215&action=review > Source/WebCore/page/Settings.yaml:443 > +honorTextSizeAdjust: This is a confusing name. Does it mean "honor the style property", so "off" means "always do text size adjust"? Why not "textSizeaAdjustForcedOn" or something?
Created attachment 368272 [details] Patch
Created attachment 368275 [details] Patch
Created attachment 368276 [details] Patch
Comment on attachment 368276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368276&action=review > Source/WebKit/Shared/WebPreferences.yaml:450 > + humanReadableName: "Text Autosizing" > + humanReadableDescription: "Enable text autosizing, which increases text size so as to be more easily read" > + category: internal > + > +ForceAutoBehaviorForTextSizeAdjust: > + type: bool > + defaultValue: false > + condition: ENABLE(TEXT_AUTOSIZING) > + humanReadableName: "Force text-size-adjust to auto" > + humanReadableDescription: "Force -webkit-text-size-adjust to behave like auto, which means web authors can't opt-out of text autosizing heuristics" > + category: internal I think you should move these down to the bottom with the other Internal features.
Comment on attachment 368276 [details] Patch Attachment 368276 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11999181 New failing tests: fast/css/first-letter-anonymous-block-crash.html
Created attachment 368289 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Test failure is unrelated.
Committed r244683: <https://trac.webkit.org/changeset/244683>
The crash on iOS Sim does appear to be related to https://trac.webkit.org/changeset/244683 . I can narrow the test list down if needed, but if you run the test from the worker of the runs it will reproduce. Crashes locally with r244683, passes with r244682 Will attach full crash log to Radar. 0 com.apple.WebCore 0x00000003ff10eb90 WebCore::RenderBlockFlow::createLineBoxes(WebCore::RenderObject*, WebCore::LineInfo const&, WebCore::InlineBox*) + 176 1 com.apple.WebCore 0x00000003ff10ef7c WebCore::RenderBlockFlow::constructLine(WebCore::BidiRunList<WebCore::BidiRun>&, WebCore::LineInfo const&) + 476 2 com.apple.WebCore 0x00000003ff111e53 WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns(unsigned int, WebCore::BidiRunList<WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::LineInfo&, WebCore::VerticalPositionCache&, WebCore::BidiRun*, WTF::Vector<WebCore::WordMeasurement, 64ul, WTF::CrashOnOverflow, 16ul>&) + 67 3 com.apple.WebCore 0x00000003ff115180 WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolverWithIsolate<WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) + 6080
Reproduces like this run-webkit-tests fast/constructors/constructor-as-function-crash.html fast/css/first-letter-and-float-crash.html fast/css/first-letter-anonymous-block-crash.html --ios-simulator --child-process 1 Myles if EWS hits the same test pattern it will bog down other patches, and it's crashing on iOS Simulator https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcss%2Ffirst-letter-anonymous-block-crash.html Please let us know if this is a quick fix.
Is causing failures on EWS https://webkit-queues.webkit.org/results/12007549
Re-opened since this is blocked by bug 197320
Having real trouble reproducing the crash.
Created attachment 368817 [details] Rebased
Comment on attachment 368817 [details] Rebased Attachment 368817 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12065529 New failing tests: fast/css/first-letter-anonymous-block-crash.html
Created attachment 368832 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4