Bug 197259 - Add SPI to set HSTS storage directory
Summary: Add SPI to set HSTS storage directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-24 16:25 PDT by Alex Christensen
Modified: 2019-05-08 16:12 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.73 KB, patch)
2019-04-24 16:51 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (11.90 KB, patch)
2019-05-07 16:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-24 16:25:40 PDT 
Add SPI to set HSTS storage directory
Comment 1 Alex Christensen 2019-04-24 16:51:34 PDT 
Created attachment 368200 [details]
Patch
Comment 2 Alex Christensen 2019-04-24 16:51:37 PDT 
<rdar://problem/48797895>
Comment 3 Alex Christensen 2019-04-24 17:08:29 PDT 
Note: requested test SPI here: rdar://problem/50188304
Comment 4 Alex Christensen 2019-05-07 16:59:42 PDT 
Created attachment 369335 [details]
Patch
Comment 5 Alex Christensen 2019-05-07 17:01:45 PDT 
Comment on attachment 369335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369335&action=review

This is ready for review.

> Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:73
> +@property (nonatomic, nullable, copy, setter=setHSTSStorageDirectory:) NSURL *hstsStorageDirectory WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

I made this an NSURL instead of an NSString to match other directories on _WKWebsiteDataStoreConfiguration.
Comment 6 WebKit Commit Bot 2019-05-08 16:12:01 PDT 
Comment on attachment 369335 [details]
Patch

Clearing flags on attachment: 369335

Committed r245075: <https://trac.webkit.org/changeset/245075>
Comment 7 WebKit Commit Bot 2019-05-08 16:12:03 PDT 
All reviewed patches have been landed.  Closing bug.