Bug 197238 - Age out unconverted Ad Click Attributions after one week.
Summary: Age out unconverted Ad Click Attributions after one week.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-24 12:26 PDT by John Wilander
Modified: 2019-04-24 14:28 PDT (History)
7 users (show)

See Also:


Attachments
Patch (25.14 KB, patch)
2019-04-24 12:34 PDT, John Wilander
no flags Details | Formatted Diff | Diff
Patch for landing (25.11 KB, patch)
2019-04-24 13:49 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-04-24 12:26:34 PDT
Unconverted Ad Click Attributions should be aged out after a week.
Comment 1 Radar WebKit Bug Importer 2019-04-24 12:27:06 PDT
<rdar://problem/50177349>
Comment 2 John Wilander 2019-04-24 12:34:56 PDT
Created attachment 368158 [details]
Patch
Comment 3 Chris Dumez 2019-04-24 12:43:10 PDT
Comment on attachment 368158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368158&action=review

> Source/WebCore/loader/AdClickAttribution.cpp:99
> +    m_timeOfAdClick = m_timeOfAdClick - maxAge - 1_s;

cannot we use m_timeOfAdClick = {} ? Then the time would be epoch, which I bet would be considered as expired.
Comment 4 John Wilander 2019-04-24 12:44:54 PDT
(In reply to Chris Dumez from comment #3)
> Comment on attachment 368158 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368158&action=review
> 
> > Source/WebCore/loader/AdClickAttribution.cpp:99
> > +    m_timeOfAdClick = m_timeOfAdClick - maxAge - 1_s;
> 
> cannot we use m_timeOfAdClick = {} ? Then the time would be epoch, which I
> bet would be considered as expired.

Oh, I'll try that. Thanks for the review!
Comment 5 John Wilander 2019-04-24 13:49:24 PDT
Created attachment 368171 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-04-24 14:28:48 PDT
Comment on attachment 368171 [details]
Patch for landing

Clearing flags on attachment: 368171

Committed r244614: <https://trac.webkit.org/changeset/244614>
Comment 7 WebKit Commit Bot 2019-04-24 14:28:49 PDT
All reviewed patches have been landed.  Closing bug.