Bug 197238 – Age out unconverted Ad Click Attributions after one week.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

Unconverted Ad Click Attributions should be aged out after a week.

[Radar WebKit Bug Importer]

<rdar://problem/50177349>

[John Wilander]

Created attachment 368158 [details]
Patch

[Chris Dumez]

Comment on attachment 368158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368158&action=review

> Source/WebCore/loader/AdClickAttribution.cpp:99
> +    m_timeOfAdClick = m_timeOfAdClick - maxAge - 1_s;

cannot we use m_timeOfAdClick = {} ? Then the time would be epoch, which I bet would be considered as expired.

[John Wilander]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 368158 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368158&action=review
> 
> > Source/WebCore/loader/AdClickAttribution.cpp:99
> > +    m_timeOfAdClick = m_timeOfAdClick - maxAge - 1_s;
> 
> cannot we use m_timeOfAdClick = {} ? Then the time would be epoch, which I
> bet would be considered as expired.

Oh, I'll try that. Thanks for the review!

[John Wilander]

Created attachment 368171 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 368171 [details]
Patch for landing

Clearing flags on attachment: 368171

Committed r244614: <https://trac.webkit.org/changeset/244614>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.