Bug 197231 - Rename _highlightLongPressCanClick and only add gesture recognizer when necessary
Summary: Rename _highlightLongPressCanClick and only add gesture recognizer when neces...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-24 04:55 PDT by Dean Jackson
Modified: 2019-04-24 05:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.08 KB, patch)
2019-04-24 05:00 PDT, Dean Jackson 		graouts: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-04-24 04:55:34 PDT 
Rename _highlightLongPressCanClick and only add gesture recognizer when necessary
Comment 1 Radar WebKit Bug Importer 2019-04-24 04:56:31 PDT 
<rdar://problem/50164234>
Comment 2 Dean Jackson 2019-04-24 05:00:48 PDT 
Created attachment 368119 [details]
Patch
Comment 3 Antoine Quint 2019-04-24 05:15:14 PDT 
Comment on attachment 368119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368119&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:756
> +    }

Maybe I'm not used to this kind of use of a block, but this looks a bit nasty to have this code only be conditionalized with a build-time flag. Could we have this wrapped in a function with an early return if the build-time flag and condition are as expected?
Comment 4 Dean Jackson 2019-04-24 05:24:01 PDT 
Committed r244586: <https://trac.webkit.org/changeset/244586>