We should promote Ad Click Attribution from internal to experimental feature.
<rdar://problem/47651691>
Created attachment 368089 [details] Patch
Comment on attachment 368089 [details] Patch R=me
Comment on attachment 368089 [details] Patch Attachment 368089 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11977676 New failing tests: js/dom/dom-static-property-for-in-iteration.html
Created attachment 368099 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Test failure is unrelated. This patch just switches a feature from internal to experimental.
Thanks, Brent!
Comment on attachment 368089 [details] Patch Clearing flags on attachment: 368089 Committed r244581: <https://trac.webkit.org/changeset/244581>
All reviewed patches have been landed. Closing bug.
It looks like the changes in https://trac.webkit.org/changeset/244581/webkit broke js/dom/dom-static-property-for-in-iteration.html EWS shows this test failed as well. Might this be a rebaseline? History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fdom-static-property-for-in-iteration.html Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/js/dom/dom-static-property-for-in-iteration-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/js/dom/dom-static-property-for-in-iteration-actual.txt @@ -9,6 +9,8 @@ PASS a["hick"] is 4 PASS a["hock"] is 5 PASS a["snood"] is 6 +PASS a["adcampaignid"] is +PASS a["addestination"] is PASS a["charset"] is PASS a["coords"] is PASS a["download"] is @@ -45,7 +47,7 @@ PASS a["contentEditable"] is inherit PASS a["isContentEditable"] is false PASS a["offsetParent"] is [object HTMLBodyElement] -PASS a["offsetTop"] is 714 +PASS a["offsetTop"] is 744 PASS a["offsetLeft"] is 8 PASS a["offsetWidth"] is 40 PASS a["offsetHeight"] is 18
Oh, shoot. It looked completely unrelated to me. Rebaseline, yes.
Rebased in https://trac.webkit.org/changeset/244592/webkit
(In reply to Truitt Savell from comment #12) > Rebased in https://trac.webkit.org/changeset/244592/webkit Thank you, Truitt. I appreciate it.