Bug 197218 - Move Ad Click Attribution from internal feature to experimental feature
Summary: Move Ad Click Attribution from internal feature to experimental feature
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
Keywords: InRadar
Depends on:
Reported: 2019-04-23 17:22 PDT by John Wilander
Modified: 2019-04-25 05:59 PDT (History)
6 users (show)

See Also:

Patch (12.95 KB, patch)
2019-04-23 17:27 PDT, John Wilander
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.71 MB, application/zip)
2019-04-23 18:46 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-04-23 17:22:40 PDT
We should promote Ad Click Attribution from internal to experimental feature.
Comment 1 John Wilander 2019-04-23 17:22:54 PDT
Comment 2 John Wilander 2019-04-23 17:27:55 PDT
Created attachment 368089 [details]
Comment 3 Brent Fulgham 2019-04-23 18:44:08 PDT
Comment on attachment 368089 [details]

Comment 4 EWS Watchlist 2019-04-23 18:46:42 PDT
Comment on attachment 368089 [details]

Attachment 368089 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11977676

New failing tests:
Comment 5 EWS Watchlist 2019-04-23 18:46:44 PDT
Created attachment 368099 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 John Wilander 2019-04-23 20:48:27 PDT
Test failure is unrelated. This patch just switches a feature from internal to experimental.
Comment 7 John Wilander 2019-04-23 20:49:19 PDT
Thanks, Brent!
Comment 8 WebKit Commit Bot 2019-04-23 21:16:35 PDT
Comment on attachment 368089 [details]

Clearing flags on attachment: 368089

Committed r244581: <https://trac.webkit.org/changeset/244581>
Comment 9 WebKit Commit Bot 2019-04-23 21:16:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Truitt Savell 2019-04-24 08:27:27 PDT
It looks like the changes in https://trac.webkit.org/changeset/244581/webkit

broke js/dom/dom-static-property-for-in-iteration.html

EWS shows this test failed as well. Might this be a rebaseline? 


--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/js/dom/dom-static-property-for-in-iteration-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/js/dom/dom-static-property-for-in-iteration-actual.txt
@@ -9,6 +9,8 @@
 PASS a["hick"] is 4
 PASS a["hock"] is 5
 PASS a["snood"] is 6
+PASS a["adcampaignid"] is 
+PASS a["addestination"] is 
 PASS a["charset"] is 
 PASS a["coords"] is 
 PASS a["download"] is 
@@ -45,7 +47,7 @@
 PASS a["contentEditable"] is inherit
 PASS a["isContentEditable"] is false
 PASS a["offsetParent"] is [object HTMLBodyElement]
-PASS a["offsetTop"] is 714
+PASS a["offsetTop"] is 744
 PASS a["offsetLeft"] is 8
 PASS a["offsetWidth"] is 40
 PASS a["offsetHeight"] is 18
Comment 11 John Wilander 2019-04-24 08:37:49 PDT
Oh, shoot. It looked completely unrelated to me. Rebaseline, yes.
Comment 12 Truitt Savell 2019-04-24 08:53:22 PDT
Rebased in https://trac.webkit.org/changeset/244592/webkit
Comment 13 John Wilander 2019-04-24 09:17:04 PDT
(In reply to Truitt Savell from comment #12)
> Rebased in https://trac.webkit.org/changeset/244592/webkit

Thank you, Truitt. I appreciate it.