Bug 197210 - Web Inspector: Debugger: remove ASSERT_NOT_REACHED where it's possible to reach
Summary: Web Inspector: Debugger: remove ASSERT_NOT_REACHED where it's possible to reach
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-23 13:55 PDT by Devin Rousso
Modified: 2019-04-23 15:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.42 KB, patch)
2019-04-23 13:57 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (4.03 KB, patch)
2019-04-23 14:06 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-23 13:55:03 PDT
It is possible for PageDebuggerAgent::didAddEventListener and PageDebuggerAgent::didPostMessage to both re-use the same object when being called, so don't assert that we haven't already seen the object.
Comment 1 Devin Rousso 2019-04-23 13:56:00 PDT
<rdar://problem/48462912>
Comment 2 Devin Rousso 2019-04-23 13:57:44 PDT
Created attachment 368060 [details]
Patch
Comment 3 Joseph Pecoraro 2019-04-23 14:01:17 PDT
Comment on attachment 368060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368060&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:1188
> +    FAST_RETURN_IF_NO_FRONTENDS(nullptr);

Is there ever a case where we would not already have fast returned if there was no frontend? This line seems unnecessary.
Comment 4 Joseph Pecoraro 2019-04-23 14:01:42 PDT
Comment on attachment 368060 [details]
Patch

r=me
Comment 5 Devin Rousso 2019-04-23 14:04:33 PDT
Comment on attachment 368060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368060&action=review

>> Source/WebCore/inspector/InspectorInstrumentation.cpp:1188
>> +    FAST_RETURN_IF_NO_FRONTENDS(nullptr);
> 
> Is there ever a case where we would not already have fast returned if there was no frontend? This line seems unnecessary.

Yeah, this one doesn't need it.
Comment 6 Devin Rousso 2019-04-23 14:06:13 PDT
Created attachment 368061 [details]
Patch
Comment 7 WebKit Commit Bot 2019-04-23 15:30:12 PDT
Comment on attachment 368061 [details]
Patch

Clearing flags on attachment: 368061

Committed r244569: <https://trac.webkit.org/changeset/244569>
Comment 8 WebKit Commit Bot 2019-04-23 15:30:14 PDT
All reviewed patches have been landed.  Closing bug.