Bug 197198 - [LFC][IFC] Introduce DisplayRun to display tree
Summary: [LFC][IFC] Introduce DisplayRun to display tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-23 07:43 PDT by zalan
Modified: 2019-05-25 13:15 PDT (History)
4 users (show)

See Also:


Attachments
Patch (143.11 KB, patch)
2019-04-23 07:52 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (144.40 KB, patch)
2019-04-23 21:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (146.39 KB, patch)
2019-04-24 16:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (147.33 KB, patch)
2019-04-24 21:36 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (148.26 KB, patch)
2019-04-25 16:05 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (196.14 KB, patch)
2019-05-21 21:41 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (196.17 KB, patch)
2019-05-22 06:23 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (199.11 KB, patch)
2019-05-23 19:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (198.63 KB, patch)
2019-05-25 11:52 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-04-23 07:43:14 PDT
ssia
Comment 1 zalan 2019-04-23 07:52:15 PDT
Created attachment 368031 [details]
Patch
Comment 2 zalan 2019-04-23 21:02:19 PDT
Created attachment 368107 [details]
Patch
Comment 3 zalan 2019-04-24 16:33:29 PDT
Created attachment 368198 [details]
Patch
Comment 4 zalan 2019-04-24 21:36:54 PDT
Created attachment 368210 [details]
Patch
Comment 5 zalan 2019-04-25 16:05:34 PDT
Created attachment 368282 [details]
Patch
Comment 6 zalan 2019-05-21 21:41:44 PDT
Created attachment 370379 [details]
Patch
Comment 7 zalan 2019-05-22 06:23:42 PDT
Created attachment 370394 [details]
Patch
Comment 8 zalan 2019-05-23 19:33:04 PDT
Created attachment 370549 [details]
Patch
Comment 9 Antti Koivisto 2019-05-24 14:40:47 PDT
Comment on attachment 370549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370549&action=review

Cool patch!

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:285
> +    // Traverse the tree and create inline items out of containers and leaf node. This essentially truns the tree inline structure into a flat one.

"leaf nodes"
"turns"

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:56
> +    {
> +    }

Weird indent.
Comment 10 zalan 2019-05-25 11:52:48 PDT
Created attachment 370639 [details]
Patch
Comment 11 WebKit Commit Bot 2019-05-25 13:14:16 PDT
Comment on attachment 370639 [details]
Patch

Clearing flags on attachment: 370639

Committed r245776: <https://trac.webkit.org/changeset/245776>
Comment 12 WebKit Commit Bot 2019-05-25 13:14:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-05-25 13:15:19 PDT
<rdar://problem/51138490>