Bug 197194 - [ews-build] Use explicit imports instead of wildcard imports
Summary: [ews-build] Use explicit imports instead of wildcard imports
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-04-23 06:27 PDT by Aakash Jain
Modified: 2019-04-23 10:55 PDT (History)
7 users (show)

See Also:

Patch (4.36 KB, patch)
2019-04-23 06:31 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-23 06:27:45 PDT
PEP8 says: "Wildcard imports (from <module> import *) should be avoided, as they make it unclear which names are present in the namespace, confusing both readers and many automated tools."


We should remove wildcard imports and use explicit imports.
Comment 1 Aakash Jain 2019-04-23 06:31:37 PDT
Created attachment 368025 [details]
Comment 2 WebKit Commit Bot 2019-04-23 10:54:40 PDT
Comment on attachment 368025 [details]

Clearing flags on attachment: 368025

Committed r244549: <https://trac.webkit.org/changeset/244549>
Comment 3 WebKit Commit Bot 2019-04-23 10:54:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-04-23 10:55:37 PDT