197193 – [ews-build] Add unit tests for DownloadBuiltProduct

RESOLVED FIXED 197193

[ews-build] Add unit tests for DownloadBuiltProduct

https://bugs.webkit.org/show_bug.cgi?id=197193

Summary [ews-build] Add unit tests for DownloadBuiltProduct

Aakash Jain

Reported 2019-04-23 05:45:29 PDT

Add unit tests for DownloadBuiltProduct build step.

Attachments
Patch (3.12 KB, patch) 2019-04-23 05:46 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-04-23 05:46:58 PDT

Created attachment 368024 [details] Patch

EWS Watchlist

Comment 2 2019-04-23 05:48:35 PDT Comment hidden (obsolete)

Attachment 368024 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:926: [TestDownloadBuiltProduct.test_success] Undefined variable 'DownloadBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:938: [TestDownloadBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:938: [TestDownloadBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:942: [TestDownloadBuiltProduct.test_failure] Undefined variable 'DownloadBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:955: [TestDownloadBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:955: [TestDownloadBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2019-04-23 10:53:31 PDT

Comment on attachment 368024 [details] Patch Clearing flags on attachment: 368024 Committed r244548: <https://trac.webkit.org/changeset/244548>

WebKit Commit Bot

Comment 4 2019-04-23 10:53:33 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-04-23 10:54:19 PDT

<rdar://problem/50135852>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version Other

Hardware Unspecified

OS Unspecified

Product WebKit

Component Tools / Tests

Assignee

Aakash Jain

Reported

2019-04-23 05:45 PDT

Modified

2019-04-23 10:54 PDT History

CC List

8 users Show

URL

Keywords InRadar

Depends on

Blocks