Bug 197185 - Action sheet shares a stringified URL instead of a URL object
Summary: Action sheet shares a stringified URL instead of a URL object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-22 19:11 PDT by Tim Horton
Modified: 2019-04-23 11:15 PDT (History)
9 users (show)

See Also:


Attachments
Patch (10.10 KB, patch)
2019-04-22 19:11 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-highsierra (2.91 MB, application/zip)
2019-04-22 20:59 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-04-22 19:11:33 PDT
Action sheet shares a stringified URL instead of a URL object
Comment 1 Tim Horton 2019-04-22 19:11:48 PDT
Created attachment 368005 [details]
Patch
Comment 2 Tim Horton 2019-04-22 19:11:49 PDT
<rdar://problem/49962249>
Comment 3 Build Bot 2019-04-22 20:59:06 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2019-04-22 20:59:07 PDT Comment hidden (obsolete)
Comment 5 Alex Christensen 2019-04-23 07:58:10 PDT
Comment on attachment 368005 [details]
Patch

No unit test?
Comment 6 Darin Adler 2019-04-23 09:24:44 PDT
Comment on attachment 368005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368005&action=review

> Source/WebKit/ChangeLog:18
> +        Make it possible to optionally provide WKShareSheet with
> +        a rect to present relative to.

Why doesn’t this bug title mention this second change? Is it related in some non-obvious way?
Comment 7 Tim Horton 2019-04-23 10:22:16 PDT
(In reply to Darin Adler from comment #6)
> Comment on attachment 368005 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=368005&action=review
> 
> > Source/WebKit/ChangeLog:18
> > +        Make it possible to optionally provide WKShareSheet with
> > +        a rect to present relative to.
> 
> Why doesn’t this bug title mention this second change? Is it related in some
> non-obvious way?

It is necessary in order to make the first change without regressing the popover tail on iPad (WKShareSheet previously would just center itself in the window, but the text selection assistant took a rect to pass through, like WKShareSheet does now).
Comment 8 WebKit Commit Bot 2019-04-23 11:15:44 PDT
Comment on attachment 368005 [details]
Patch

Clearing flags on attachment: 368005

Committed r244553: <https://trac.webkit.org/changeset/244553>
Comment 9 WebKit Commit Bot 2019-04-23 11:15:46 PDT
All reviewed patches have been landed.  Closing bug.