Bug 197180 – [ews-build] Trigger queues only after uploading the archive

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Builders should trigger tester queues only after uploading the archive. Currently the trigger step is run even if WebKit fails to compile. In that case the triggered build always fails with the error 'Downloaded built product (failure)'. This is because archive was never uploaded after WebKit failed to Compile.

e.g.:
https://ews-build.webkit.org/#/builders/7/builds/962
https://ews-build.webkit.org/#/builders/3/builds/871


We should triggers the testers only after the Upload step is successfully complete.

[Aakash Jain]

Created attachment 367989 [details]
Patch

[EWS Watchlist]

Attachment 367989 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:46:  [ConfigureBuild.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:390:  [Trigger.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:697:  [UploadBuiltProduct.finished] Use of super on an old style class  [pylint/E1002] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lucas Forschler]

Comment on attachment 367989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367989&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:394
> +    def propertiesToPassToTriggers(self):

how about renaming this to triggerProperties?
otherwise, lgtm!

[WebKit Commit Bot]

Comment on attachment 367989 [details]
Patch

Clearing flags on attachment: 367989

Committed r244532: <https://trac.webkit.org/changeset/244532>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/50113791>