Bug 197180 - [ews-build] Trigger queues only after uploading the archive
Summary: [ews-build] Trigger queues only after uploading the archive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-22 15:53 PDT by Aakash Jain
Modified: 2019-04-22 17:17 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.99 KB, patch)
2019-04-22 16:09 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-04-22 15:53:30 PDT
Builders should trigger tester queues only after uploading the archive. Currently the trigger step is run even if WebKit fails to compile. In that case the triggered build always fails with the error 'Downloaded built product (failure)'. This is because archive was never uploaded after WebKit failed to Compile.

e.g.:
https://ews-build.webkit.org/#/builders/7/builds/962
https://ews-build.webkit.org/#/builders/3/builds/871


We should triggers the testers only after the Upload step is successfully complete.
Comment 1 Aakash Jain 2019-04-22 16:09:34 PDT
Created attachment 367989 [details]
Patch
Comment 2 Build Bot 2019-04-22 16:12:07 PDT Comment hidden (obsolete)
Comment 3 Lucas Forschler 2019-04-22 16:44:28 PDT
Comment on attachment 367989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367989&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:394
> +    def propertiesToPassToTriggers(self):

how about renaming this to triggerProperties?
otherwise, lgtm!
Comment 4 WebKit Commit Bot 2019-04-22 17:16:53 PDT
Comment on attachment 367989 [details]
Patch

Clearing flags on attachment: 367989

Committed r244532: <https://trac.webkit.org/changeset/244532>
Comment 5 WebKit Commit Bot 2019-04-22 17:16:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-22 17:17:17 PDT
<rdar://problem/50113791>