Bug 197173 - [CMake][Win] Use target oriented design for WebKit
Summary: [CMake][Win] Use target oriented design for WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 196704
  Show dependency tree / graph
 
Reported: 2019-04-22 12:38 PDT by Don Olmstead
Modified: 2019-04-23 08:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (23.90 KB, patch)
2019-04-22 12:53 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (24.04 KB, patch)
2019-04-22 13:11 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-04-22 12:38:07 PDT 
Copy the headers. Set a specific derived sources directory.
Comment 1 Don Olmstead 2019-04-22 12:53:48 PDT 
Created attachment 367962 [details]
Patch
Comment 2 Don Olmstead 2019-04-22 13:01:54 PDT 
I'm not totally ready to try and make GTK/WPE work with copied WebKit headers. I do however want to continue on with https://bugs.webkit.org/show_bug.cgi?id=197174 which will refactor the copying targets.
Comment 3 Don Olmstead 2019-04-22 13:11:55 PDT 
Created attachment 367964 [details]
Patch
Comment 4 WebKit Commit Bot 2019-04-23 08:55:07 PDT 
Comment on attachment 367964 [details]
Patch

Clearing flags on attachment: 367964

Committed r244541: <https://trac.webkit.org/changeset/244541>
Comment 5 WebKit Commit Bot 2019-04-23 08:55:08 PDT 
All reviewed patches have been landed.  Closing bug.