Bug 197170 - [PlayStation] Support running of JSC tests on remote playstation devices
Summary: [PlayStation] Support running of JSC tests on remote playstation devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-22 11:19 PDT by Stephan Szabo
Modified: 2019-04-23 09:11 PDT (History)
11 users (show)

See Also:

Attachments
Patch (20.03 KB, patch)
2019-04-22 11:26 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2019-04-22 11:19:40 PDT 
Update Tools for running JSC tests on playstation devices using internal remote execution tools.
Comment 1 Stephan Szabo 2019-04-22 11:26:01 PDT 
Created attachment 367956 [details]
Patch
Comment 2 Ross Kirsling 2019-04-22 16:58:06 PDT 
Comment on attachment 367956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367956&action=review

> Tools/Scripts/webkitdirs.pm:779
> +    if (isAnyWindows() && !isPlayStation()) {

I wish there were a way to write this without baking in the idea that isPlayStation implies isAnyWindows but it makes sense to have the bin[64|32] branch first.
Comment 3 WebKit Commit Bot 2019-04-23 09:10:59 PDT 
Comment on attachment 367956 [details]
Patch

Clearing flags on attachment: 367956

Committed r244543: <https://trac.webkit.org/changeset/244543>
Comment 4 WebKit Commit Bot 2019-04-23 09:11:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-04-23 09:11:22 PDT 
<rdar://problem/50131796>