Bug 197163 - [GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value
Summary: [GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-22 09:53 PDT by Zan Dobersek
Modified: 2019-07-31 08:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2019-04-22 09:54 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2019-04-22 09:53:29 PDT
[GLib] Remove unused MainThreadSharedTimer RunLoopSourcePriority value
Comment 1 Zan Dobersek 2019-04-22 09:54:40 PDT
Created attachment 367946 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-04-23 03:15:13 PDT
Comment on attachment 367946 [details]
Patch

I think this is actually a typo in Source/WTF/wtf/generic/MainThreadGeneric.cpp, it should use MainThreadSharedTimer instead of MainThreadDispatcherTimer. It doesn't matter because we use the same priority but we might change it in the future. MainThreadDispatcherTimer is the priority for timers used to send tasks to the main thread run loop like callOnMainThread().
Comment 3 Zan Dobersek 2019-05-06 00:44:32 PDT
Comment on attachment 367946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367946&action=review

> Source/WTF/wtf/glib/RunLoopSourcePriority.h:-58
> -    // WebCore timers.
> -    MainThreadSharedTimer = 100,

Per this comment, MainThreadSharedTimer priority should be used in the WebCore::MainThreadSharedTimer class.
Comment 4 Zan Dobersek 2019-05-06 00:49:03 PDT
Continued in bug #197606.