Patch started.
Created attachment 368035 [details] Patch
Comment on attachment 368035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368035&action=review Nice cleanup! Informal r+ Looks good to me :-) > Tools/flatpak/files/httpd-autogen.sh:3 > +autoreconf --install ooc, Why is that better/needed? > Tools/flatpak/org.webkit.CommonModules.yaml:199 > + sha256: 80bb685abfcdda7c9b6c9c5caf1d8dbb927858050d7377c2b8f3488c7e8a9b7f We could use the meson port to build faster and use what has been tested? https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg
Comment on attachment 368035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368035&action=review >> Tools/flatpak/files/httpd-autogen.sh:3 >> +autoreconf --install > > ooc, Why is that better/needed? It is needed for the 3.32 Sdk, which, it seems, has an updated autofools suite which complained here with the autoreconf call. I can find the error again if needed. >> Tools/flatpak/org.webkit.CommonModules.yaml:199 >> + sha256: 80bb685abfcdda7c9b6c9c5caf1d8dbb927858050d7377c2b8f3488c7e8a9b7f > > We could use the meson port to build faster and use what has been tested? https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg I didn't know about this one, I can add it yeah :)
EWS failed: Dependency libavfilter found: NO (tried pkgconfig) Looking for a fallback subproject for the dependency libavfilter Couldn't use fallback subproject in subprojects/FFmpeg for the dependency libavfilter Reason: Subproject directory 'subprojects/FFmpeg' does not exist and cannot be downloaded: No FFmpeg.wrap found for 'subprojects/FFmpeg' meson.build:18:0: ERROR: Dependency "libavfilter" not found, tried pkgconfig Should we use the FFMpeg Meson port in jhbuild too?
> Should we use the FFMpeg Meson port in jhbuild too? Could be yes
Comment on attachment 368035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368035&action=review >>> Tools/flatpak/files/httpd-autogen.sh:3 >>> +autoreconf --install >> >> ooc, Why is that better/needed? > > It is needed for the 3.32 Sdk, which, it seems, has an updated autofools suite which complained here with the autoreconf call. I can find the error again if needed. ======================================================================== Building module httpd in /home/phil/WebKit/WebKitBuild/FlatpakCache/build/httpd-9 ======================================================================== Note: checking out '2.4.37'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b <new-branch-name> HEAD is now at 39902c8 Tag HEAD of 2.4.x as 2.4.37 Applying patch httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch patching file configure.in aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in' checking for chosen layout... Apache checking for working mkdir -p... yes checking for grep that handles long lines and -e... /usr/bin/grep checking for egrep... /usr/bin/grep -E configure: error: cannot run /bin/sh build/config.sub Error: module httpd: Child process exited with code 127 Traceback (most recent call last): File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module> sys.exit(WebkitFlatpak.load_from_args().run()) File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 844, in run return self.setup_dev_env() File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 889, in setup_dev_env subprocess.check_call(builder_args) File "/usr/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['flatpak-builder', '--disable-rofiles-fuse', '--state-dir', '/home/phil/WebKit/WebKitBuild/FlatpakCache', '--ccache', '/home/phil/WebKit/WebKitBuild/WPE/FlatpakTreeRelease', '--force-clean', '/home/phil/WebKit/WebKitBuild/FlatpakCache/org.webkit.WPE-generated.json', '--build-only', '--stop-at=org.webkit.WPE']' returned non-zero exit status 1 >>> Tools/flatpak/org.webkit.CommonModules.yaml:199 >>> + sha256: 80bb685abfcdda7c9b6c9c5caf1d8dbb927858050d7377c2b8f3488c7e8a9b7f >> >> We could use the meson port to build faster and use what has been tested? https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg > > I didn't know about this one, I can add it yeah :) Not possible yet, https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg/issues/7
Created attachment 368114 [details] Patch
Comment on attachment 368114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368114&action=review > Tools/gstreamer/jhbuild.modules:112 > + </meson> It looks there is an extra space at the beginning of this line
> Not possible yet, https://gitlab.freedesktop.org/gstreamer/meson-ports/ffmpeg/issues/7 Oops, whatever :-)
Committed r244585: <https://trac.webkit.org/changeset/244585>
<rdar://problem/50164710>