Bug 197156 - [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
Summary: [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2019-04-22 03:57 PDT by Carlos Garcia Campos
Modified: 2019-04-24 00:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.66 KB, patch)
2019-04-22 04:07 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-04-22 03:57:42 PDT 
The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs support was added.
Comment 1 Carlos Garcia Campos 2019-04-22 04:07:07 PDT 
Created attachment 367935 [details]
Patch
Comment 2 EWS Watchlist 2019-04-22 04:08:55 PDT 
Attachment 367935 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/gtk/BrowserTab.h:57:  browser_tab_set_background_color is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Tools/MiniBrowser/gtk/BrowserTab.c:607:  browser_tab_set_background_color is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Catanzaro 2019-04-22 08:58:39 PDT 
Please add these files to the style checker whitelist.
Comment 4 Carlos Garcia Campos 2019-04-24 00:54:04 PDT 
Committed r244583: <https://trac.webkit.org/changeset/244583>
Comment 5 Radar WebKit Bug Importer 2019-04-24 00:55:18 PDT 
<rdar://problem/50159645>