Bug 197153 - [JSC] useJIT should subsume useRegExpJIT
Summary: [JSC] useJIT should subsume useRegExpJIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-22 02:45 PDT by Yusuke Suzuki
Modified: 2019-05-10 09:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.56 KB, patch)
2019-04-22 02:45 PDT, Yusuke Suzuki
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-04-22 02:45:10 PDT
[JSC] useJIT should subsume useRegExpJIT
Comment 1 Yusuke Suzuki 2019-04-22 02:45:56 PDT
Created attachment 367930 [details]
Patch
Comment 2 Build Bot 2019-04-22 02:48:21 PDT
Attachment 367930 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/RegExp.cpp:261:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/runtime/RegExp.cpp:319:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2019-04-22 11:30:37 PDT
Committed r244505: <https://trac.webkit.org/changeset/244505>
Comment 4 Radar WebKit Bug Importer 2019-04-22 11:31:41 PDT
<rdar://problem/50100848>
Comment 5 Yusuke Suzuki 2019-05-10 09:18:40 PDT
This improved some memory footprint in useJIT=false environment since, perviously, even if useJIT=false is specified, we still have useRegExpJIT=false, and  we attempt to initialize ExecutableAllocator and being rejected by entitlements. Now we do not do that.