Bug 197145 – Defer EditorState updates until the next layer tree flush in a few additional circumstances

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

Examples include after changing editability, showing the font manager on macOS, and after a selection change.

[Radar WebKit Bug Importer]

<rdar://problem/50078170>

[Wenson Hsieh]

Created attachment 367904 [details]
Patch

[Wenson Hsieh]

Comment on attachment 367904 [details]
Patch

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 367904 [details]
Patch

Clearing flags on attachment: 367904

Committed r244494: <https://trac.webkit.org/changeset/244494>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/244494/webkit

has caused the test editing/pasteboard/5761530-1.html to become flakey. 

I was able to reproduce this using command:
run-webkit-tests editing/pasteboard/5761530-1.html --iterations 20 --ios-simulator
The test passes on 244493 and with fail on 244494

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fpasteboard%2F5761530-1.html

Diff:
--- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/editing/pasteboard/5761530-1-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/editing/pasteboard/5761530-1-actual.txt
@@ -1,3 +1,3 @@
 This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.
 
-<span class="Apple-tab-span" style="white-space: pre;">	</span><span class="Apple-tab-span" style="white-space:pre;">	</span>xxx
+<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space:pre;"> </span>xxx

[Ryosuke Niwa]

That's rather surprising. The test doesn't seem like it would depend anything related to EditorState.

[Ryosuke Niwa]

Filed https://bugs.webkit.org/show_bug.cgi?id=197438 to track the test flakiness.

[Alexey Proskuryakov]

EWS did hit this failure, but since it is flaky, it wasn't reported. Perhaps we could eventually develop some logic for EWS to dig into flaky failures.