Bug 197126 - [WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext
Summary: [WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-19 16:27 PDT by Justin Fan
Modified: 2019-04-22 11:42 PDT (History)
8 users (show)

See Also:

Attachments
Patch (24.59 KB, patch)
2019-04-19 16:51 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch for landing (24.55 KB, patch)
2019-04-22 11:02 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-04-19 16:27:41 PDT 
[WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext
Comment 1 Justin Fan 2019-04-19 16:51:29 PDT 
Created attachment 367854 [details]
Patch
Comment 2 Dean Jackson 2019-04-22 10:54:14 PDT 
Comment on attachment 367854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367854&action=review

> Source/WebCore/Modules/webgpu/GPUCanvasContext.idl:36
> +    GPUTextureUsageFlags usage; // = GPUTextureUsage.OUTPUT_ATTACHMENT;

Please leave the "FIXME" in here so we can find it.
Comment 3 Justin Fan 2019-04-22 11:02:48 PDT 
Created attachment 367952 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-04-22 11:41:22 PDT 
Comment on attachment 367952 [details]
Patch for landing

Clearing flags on attachment: 367952

Committed r244507: <https://trac.webkit.org/changeset/244507>
Comment 5 WebKit Commit Bot 2019-04-22 11:41:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-22 11:42:22 PDT 
<rdar://problem/50101236>