Bug 197122 - Use RetainPtr and rename +autocorrectionRectsWithRects:lastRect: to +autocorrectionRectsWithFirstCGRect:lastCGRect:
Summary: Use RetainPtr and rename +autocorrectionRectsWithRects:lastRect: to +autocorr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-19 14:55 PDT by Daniel Bates
Modified: 2019-04-19 16:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2019-04-19 15:17 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-04-19 14:55:31 PDT 
Smarter code uses smart pointers :) (Sounded better in my head) and why not rename +autocorrectionRectsWithRects to autocorrectionRectsWithCGRects to make it clear what kinds of rects we expect: CGRects of course!
Comment 1 Daniel Bates 2019-04-19 15:00:57 PDT 
I still don't like the name.... +autocorrectionRectsWithCGRects... hmm.
Comment 2 Daniel Bates 2019-04-19 15:02:09 PDT 
+autocorrectionRectsWithFirstCGRect:lastCGRect:?
Comment 3 Daniel Bates 2019-04-19 15:17:59 PDT 
Created attachment 367841 [details]
Patch

Went with +autocorrectionRectsWithFirstCGRect:lastCGRect:. It is a bit more verbose than I would like. I would need to understand the purpose of these rects to have a chance at a coming up with a better name I think.
Comment 4 Daniel Bates 2019-04-19 16:49:13 PDT 
Comment on attachment 367841 [details]
Patch

Clearing flags on attachment: 367841

Committed r244474: <https://trac.webkit.org/changeset/244474>
Comment 5 Daniel Bates 2019-04-19 16:49:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-19 16:50:20 PDT 
<rdar://problem/50064037>