Bug 197117 - Add more _WKElementActionTypes and provide API to create with custom types
Summary: Add more _WKElementActionTypes and provide API to create with custom types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-19 14:28 PDT by Dean Jackson
Modified: 2019-04-19 15:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.35 KB, patch)
2019-04-19 14:34 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (4.42 KB, patch)
2019-04-19 14:42 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2019-04-19 14:57 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-04-19 14:28:09 PDT
Add more _WKElementActionTypes and provide API to create with custom types
Comment 1 Radar WebKit Bug Importer 2019-04-19 14:28:36 PDT
<rdar://problem/50059548>
Comment 2 Dean Jackson 2019-04-19 14:34:10 PDT
Created attachment 367828 [details]
Patch
Comment 3 Dean Jackson 2019-04-19 14:42:42 PDT
Created attachment 367831 [details]
Patch
Comment 4 Tim Horton 2019-04-19 14:44:16 PDT
Comment on attachment 367831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367831&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:45
> +    _WKElementActionTypeShare WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(10.0)),

This one shouldn't be TBA

> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:55
> -+ (instancetype)elementActionWithType:(_WKElementActionType)type customTitle:(NSString *)title;
> ++ (instancetype)elementActionWithType:(_WKElementActionType)type title:(NSString *)title actionHandler:(WKElementActionHandler)actionHandler;

Are you sure there are no clients of the old SPI‽ Also, this needs availability.
Comment 5 Dean Jackson 2019-04-19 14:57:41 PDT
Created attachment 367835 [details]
Patch
Comment 6 Dean Jackson 2019-04-19 15:25:10 PDT
Committed r244472: <https://trac.webkit.org/changeset/244472>