Bug 197115 - Web Inspector: Timelines: CPU: ensure that tracking stops when disconnecting Web Inspector
Summary: Web Inspector: Timelines: CPU: ensure that tracking stops when disconnecting ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-19 14:02 PDT by Devin Rousso
Modified: 2019-04-19 17:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2019-04-19 14:03 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-19 14:02:31 PDT 
It may be possible to UAF the `InspectorCPUProfilerAgent`, since it adds itself (via a C++ lambda) as an observer to another object.  If the inspector disconnects while actively recording, we currently don't remove that.
Comment 1 Devin Rousso 2019-04-19 14:02:42 PDT 
<rdar://problem/49877875>
Comment 2 Devin Rousso 2019-04-19 14:03:33 PDT 
Created attachment 367823 [details]
Patch
Comment 3 Joseph Pecoraro 2019-04-19 16:24:24 PDT 
Comment on attachment 367823 [details]
Patch

r=me. Are there any other agents that could benefit from this?
Comment 4 Devin Rousso 2019-04-19 16:27:15 PDT 
(In reply to Joseph Pecoraro from comment #3)
> r=me. Are there any other agents that could benefit from this?
I checked the other timelines agents, and all of them either weren't susceptible  or already had a "fix" for this issue.
Comment 5 WebKit Commit Bot 2019-04-19 17:33:26 PDT 
Comment on attachment 367823 [details]
Patch

Clearing flags on attachment: 367823

Committed r244478: <https://trac.webkit.org/changeset/244478>
Comment 6 WebKit Commit Bot 2019-04-19 17:33:27 PDT 
All reviewed patches have been landed.  Closing bug.