197113 – [PSON] Use WebProcessProxy::registrableDomain() to make process-swapping decision

ASSIGNED197113

[PSON] Use WebProcessProxy::registrableDomain() to make process-swapping decision

https://bugs.webkit.org/show_bug.cgi?id=197113

Summary [PSON] Use WebProcessProxy::registrableDomain() to make process-swapping deci...

Chris Dumez

Reported 2019-04-19 13:03:56 PDT

Use WebProcessProxy::registrableDomain() to make process-swapping decisions, inside of passing a sourceURL around. This is safest and simplifies the code.

Attachments
Patch (16.07 KB, patch) 2019-04-19 13:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (18.52 KB, patch) 2019-04-19 17:01 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.92 MB, application/zip) 2019-04-19 19:16 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (10.29 MB, application/zip) 2019-04-19 19:17 PDT, EWS Watchlist	no flags	Details
Patch (18.74 KB, patch) 2019-04-19 20:58 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.82 MB, application/zip) 2019-04-19 22:27 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (15.49 MB, application/zip) 2019-04-19 23:09 PDT, EWS Watchlist	no flags	Details
Patch (18.71 KB, patch) 2019-04-20 11:34 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (21.16 KB, patch) 2019-04-20 12:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.25 MB, application/zip) 2019-04-20 16:14 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (3.17 MB, application/zip) 2019-04-20 21:12 PDT, EWS Watchlist	no flags	Details
Patch (23.82 KB, patch) 2019-04-21 12:07 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (23.74 KB, patch) 2019-04-21 13:15 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (30.63 KB, patch) 2019-04-21 15:25 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.87 MB, application/zip) 2019-04-21 20:08 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.90 MB, application/zip) 2019-04-22 18:23 PDT, EWS Watchlist	no flags	Details
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-04-19 13:06:53 PDT

Created attachment 367816 [details] Patch

Chris Dumez

Comment 2 2019-04-19 17:01:45 PDT

Created attachment 367855 [details] Patch

EWS Watchlist

Comment 3 2019-04-19 19:16:03 PDT

Comment on attachment 367855 [details] Patch Attachment 367855 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11937412 New failing tests: fast/history/page-cache-element-state-focused.html imported/blink/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html http/tests/navigation/go-back-to-error-page.html ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm imported/blink/fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html

EWS Watchlist

Comment 4 2019-04-19 19:16:05 PDT

Created attachment 367862 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-04-19 19:17:16 PDT

Comment on attachment 367855 [details] Patch Attachment 367855 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11937126 New failing tests: imported/blink/svg/as-object/history-navigation.html imported/blink/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html http/tests/navigation/go-back-to-error-page.html legacy-animation-engine/fast/animation/animation-mixed-transform-crash.html http/tests/misc/webtiming-cross-origin-redirect.php imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/window-name-after-cross-origin-sub-frame-navigation.sub.html imported/blink/fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html

EWS Watchlist

Comment 6 2019-04-19 19:17:18 PDT

Created attachment 367863 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 7 2019-04-19 20:58:39 PDT

Created attachment 367870 [details] Patch

EWS Watchlist

Comment 8 2019-04-19 22:27:38 PDT

Comment on attachment 367870 [details] Patch Attachment 367870 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11938376 New failing tests: ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm

EWS Watchlist

Comment 9 2019-04-19 22:27:40 PDT

Created attachment 367875 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 10 2019-04-19 22:57:24 PDT

Comment on attachment 367875 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 Looks like a flaky test. This test does not process-swap.

EWS Watchlist

Comment 11 2019-04-19 23:09:48 PDT

Comment on attachment 367870 [details] Patch Attachment 367870 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11938422 New failing tests: http/tests/misc/webtiming-cross-origin-redirect.php

EWS Watchlist

Comment 12 2019-04-19 23:09:50 PDT

Created attachment 367880 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 13 2019-04-20 11:34:46 PDT

Created attachment 367897 [details] Patch

Chris Dumez

Comment 14 2019-04-20 12:49:37 PDT

Created attachment 367898 [details] Patch

EWS Watchlist

Comment 15 2019-04-20 16:14:01 PDT

Comment on attachment 367898 [details] Patch Attachment 367898 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11942526 New failing tests: http/tests/misc/webtiming-cross-origin-redirect.php

EWS Watchlist

Comment 16 2019-04-20 16:14:04 PDT

Created attachment 367900 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 17 2019-04-20 21:12:00 PDT

Comment on attachment 367898 [details] Patch Attachment 367898 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11943565 New failing tests: http/tests/contentextensions/block-everything-unless-domain-redirect.php ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm

EWS Watchlist

Comment 18 2019-04-20 21:12:03 PDT

Created attachment 367902 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Chris Dumez

Comment 19 2019-04-21 12:07:56 PDT

Created attachment 367914 [details] Patch

Chris Dumez

Comment 20 2019-04-21 13:15:54 PDT

Created attachment 367916 [details] Patch

Chris Dumez

Comment 21 2019-04-21 15:25:39 PDT

Created attachment 367918 [details] Patch

EWS Watchlist

Comment 22 2019-04-21 20:08:57 PDT

Comment on attachment 367918 [details] Patch Attachment 367918 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11947800 New failing tests: ietestcenter/css3/flexbox/flexbox-align-end-001.htm

EWS Watchlist

Comment 23 2019-04-21 20:08:59 PDT

Created attachment 367923 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 24 2019-04-22 18:23:27 PDT

Comment on attachment 367918 [details] Patch Attachment 367918 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11967441 New failing tests: imported/w3c/web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001.html

EWS Watchlist

Comment 25 2019-04-22 18:23:29 PDT

Created attachment 368003 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Note You need to log in before you can comment on or make changes to this bug.

Status ASSIGNED

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit2

Assignee

Chris Dumez

Reported

2019-04-19 13:03 PDT

Modified

2019-04-22 18:23 PDT History

CC List

6 users Show

URL

Keywords

Depends on

Blocks