Bug 197106 - Eagerly parse immediately invoked functions
Summary: Eagerly parse immediately invoked functions
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
: 202674 (view as bug list)
Depends on: 206706
Blocks:
  Show dependency tree / graph
 
Reported: 2019-04-19 10:36 PDT by Saam Barati
Modified: 2020-01-30 12:41 PST (History)
14 users (show)

See Also:

Attachments
WIP (48.24 KB, patch)
2020-01-25 12:00 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (53.13 KB, patch)
2020-01-27 18:11 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (53.22 KB, patch)
2020-01-27 18:40 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (55.75 KB, patch)
2020-01-28 15:17 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (57.44 KB, patch)
2020-01-29 17:58 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-04-19 10:36:25 PDT 
We should develop a heuristic around doing this. This will help parsing time for such code because we won't spend the extra time syntax checking.
Comment 1 Radar WebKit Bug Importer 2019-04-19 10:41:33 PDT 
<rdar://problem/50052023>
Comment 2 Saam Barati 2019-10-20 21:56:35 PDT 
*** Bug 202674 has been marked as a duplicate of this bug. ***
Comment 3 Saam Barati 2020-01-23 12:09:20 PST 
Gonna give this a go
Comment 4 Saam Barati 2020-01-25 12:00:41 PST 
Created attachment 388785 [details]
WIP

it begins
Comment 5 Saam Barati 2020-01-27 18:11:14 PST 
Created attachment 388954 [details]
WIP

it eagerly parsed something, but crashed in emitting debug info
Comment 6 Saam Barati 2020-01-27 18:40:29 PST 
Created attachment 388957 [details]
WIP

no longer crashing in emitExpressionInfo
Comment 7 Saam Barati 2020-01-28 15:17:36 PST 
Created attachment 389073 [details]
WIP

seems to work for functions.
Comment 8 Saam Barati 2020-01-29 11:17:05 PST 
Seems neutral on major benchmarks. It is a speedup on microbenchmarks
Comment 9 Saam Barati 2020-01-29 17:58:22 PST 
Created attachment 389208 [details]
WIP

Seems to work, but isn't really a speedup :(