Bug 197104 - Minor PSON release logging improvements
Summary: Minor PSON release logging improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-19 08:50 PDT by Chris Dumez
Modified: 2019-04-19 13:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2019-04-19 08:52 PDT, Chris Dumez 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-04-19 08:50:31 PDT 
Minor PSON release logging improvements.
Comment 1 Chris Dumez 2019-04-19 08:52:26 PDT 
Created attachment 367802 [details]
Patch
Comment 2 Darin Adler 2019-04-19 10:02:55 PDT 
Comment on attachment 367802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367802&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2874
> +    RELEASE_LOG_IF_ALLOWED(Loading, "continueNavigationInNewProcess: webPID = %i, pageID = %" PRIu64 ", newProcessPID = %i, hasSuspendedPage = %d", m_process->processIdentifier(), m_pageID, newProcess->processIdentifier(), !!suspendedPageProxy);

Strange to use both %i and %d when they are synonyms.
Comment 3 Chris Dumez 2019-04-19 13:09:08 PDT 
Committed r244464: <https://trac.webkit.org/changeset/244464>
Comment 4 Radar WebKit Bug Importer 2019-04-19 13:10:19 PDT 
<rdar://problem/50056848>