Bug 197080 - Deprecate WebKit2 plug-in support
Summary: Deprecate WebKit2 plug-in support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on: 197103
Blocks:
  Show dependency treegraph
 
Reported: 2019-04-18 15:58 PDT by Brady Eidson
Modified: 2019-04-19 14:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.55 KB, patch)
2019-04-18 16:54 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (4.56 KB, patch)
2019-04-18 17:01 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (4.51 KB, patch)
2019-04-19 12:44 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2019-04-18 15:58:50 PDT
Deprecate WebKit2 plug-in support

<rdar://problem/43812306>
Comment 1 Brady Eidson 2019-04-18 16:54:48 PDT
Created attachment 367776 [details]
Patch
Comment 2 Andy Estes 2019-04-18 17:01:09 PDT
Comment on attachment 367776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367776&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:70
> +@property (nonatomic) BOOL javaEnabled WK_API_DEPRECATED("Java is no longer supported", macos(WK_MAC_TBA, WK_MAC_TBA));
> +@property (nonatomic) BOOL plugInsEnabled WK_API_DEPRECATED("Plug-ins are no longer supported", macos(WK_MAC_TBA, WK_MAC_TBA));

The first WK_MAC_TBA should instead be the release that introduced the property.
Comment 3 Brady Eidson 2019-04-18 17:01:12 PDT
Created attachment 367777 [details]
Patch
Comment 4 WebKit Commit Bot 2019-04-18 19:37:00 PDT
Comment on attachment 367777 [details]
Patch

Clearing flags on attachment: 367777

Committed r244447: <https://trac.webkit.org/changeset/244447>
Comment 5 WebKit Commit Bot 2019-04-18 19:37:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Robin Morisset 2019-04-18 19:58:57 PDT
This broke the build for me:
/Users/rmorisset/Webkit/OpenSource/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:69:92: error: expected a version of the form 'major[.minor[.subminor]]'
@property (nonatomic) BOOL javaEnabled API_DEPRECATED("Java is no longer supported", macos(macos(10.10), 10.14.4));
                                                                                           ^
/Users/rmorisset/Webkit/OpenSource/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:70:100: error: expected a version of the form 'major[.minor[.subminor]]'
@property (nonatomic) BOOL plugInsEnabled API_DEPRECATED("Plug-ins are no longer supported", macos(macos(10.10), 10.14.4));

Replacing macOS(10.10) by 10.10 fixed it.
I don't know why it did not break the build for the bots.
Comment 7 Brady Eidson 2019-04-18 21:03:01 PDT
That is truly odd. Also built locally for me on two different OSes, and the formatting in this patch can be seen elsewhere. 🤔
Comment 8 Shawn Roberts 2019-04-19 08:43:15 PDT
Rolled out in https://trac.webkit.org/changeset/244451/webkit

Was causing OpenSource and Internal builders to fail.

https://build.webkit.org/builders/Apple%20Mojave%20Release%20%28Build%29/builds/5069/steps/compile-webkit/logs/stdio

In file included from /Volumes/Data/slave/mojave-release/build/Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch:28:
In file included from /Volumes/Data/slave/mojave-release/build/WebKitBuild/Release/WebKit.framework/Headers/WebKit.h:39:
/Volumes/Data/slave/mojave-release/build/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:69:92: error: expected a version of the form 'major[.minor[.subminor]]'
@property (nonatomic) BOOL javaEnabled API_DEPRECATED("Java is no longer supported", macos(macos(10.10), 10.14));
                                                                                           ^
/Volumes/Data/slave/mojave-release/build/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:70:100: error: expected a version of the form 'major[.minor[.subminor]]'
@property (nonatomic) BOOL plugInsEnabled API_DEPRECATED("Plug-ins are no longer supported", macos(macos(10.10), 10.14));
Comment 9 Brady Eidson 2019-04-19 12:44:52 PDT
Created attachment 367812 [details]
Patch
Comment 10 WebKit Commit Bot 2019-04-19 14:04:30 PDT
Comment on attachment 367812 [details]
Patch

Clearing flags on attachment: 367812

Committed r244465: <https://trac.webkit.org/changeset/244465>
Comment 11 WebKit Commit Bot 2019-04-19 14:04:31 PDT
All reviewed patches have been landed.  Closing bug.