Deprecate WebKit2 plug-in support <rdar://problem/43812306>
Created attachment 367776 [details] Patch
Comment on attachment 367776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367776&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:70 > +@property (nonatomic) BOOL javaEnabled WK_API_DEPRECATED("Java is no longer supported", macos(WK_MAC_TBA, WK_MAC_TBA)); > +@property (nonatomic) BOOL plugInsEnabled WK_API_DEPRECATED("Plug-ins are no longer supported", macos(WK_MAC_TBA, WK_MAC_TBA)); The first WK_MAC_TBA should instead be the release that introduced the property.
Created attachment 367777 [details] Patch
Comment on attachment 367777 [details] Patch Clearing flags on attachment: 367777 Committed r244447: <https://trac.webkit.org/changeset/244447>
All reviewed patches have been landed. Closing bug.
This broke the build for me: /Users/rmorisset/Webkit/OpenSource/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:69:92: error: expected a version of the form 'major[.minor[.subminor]]' @property (nonatomic) BOOL javaEnabled API_DEPRECATED("Java is no longer supported", macos(macos(10.10), 10.14.4)); ^ /Users/rmorisset/Webkit/OpenSource/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:70:100: error: expected a version of the form 'major[.minor[.subminor]]' @property (nonatomic) BOOL plugInsEnabled API_DEPRECATED("Plug-ins are no longer supported", macos(macos(10.10), 10.14.4)); Replacing macOS(10.10) by 10.10 fixed it. I don't know why it did not break the build for the bots.
That is truly odd. Also built locally for me on two different OSes, and the formatting in this patch can be seen elsewhere. 🤔
Rolled out in https://trac.webkit.org/changeset/244451/webkit Was causing OpenSource and Internal builders to fail. https://build.webkit.org/builders/Apple%20Mojave%20Release%20%28Build%29/builds/5069/steps/compile-webkit/logs/stdio In file included from /Volumes/Data/slave/mojave-release/build/Tools/MiniBrowser/mac/MiniBrowser_Prefix.pch:28: In file included from /Volumes/Data/slave/mojave-release/build/WebKitBuild/Release/WebKit.framework/Headers/WebKit.h:39: /Volumes/Data/slave/mojave-release/build/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:69:92: error: expected a version of the form 'major[.minor[.subminor]]' @property (nonatomic) BOOL javaEnabled API_DEPRECATED("Java is no longer supported", macos(macos(10.10), 10.14)); ^ /Volumes/Data/slave/mojave-release/build/WebKitBuild/Release/WebKit.framework/Headers/WKPreferences.h:70:100: error: expected a version of the form 'major[.minor[.subminor]]' @property (nonatomic) BOOL plugInsEnabled API_DEPRECATED("Plug-ins are no longer supported", macos(macos(10.10), 10.14));
Created attachment 367812 [details] Patch
Comment on attachment 367812 [details] Patch Clearing flags on attachment: 367812 Committed r244465: <https://trac.webkit.org/changeset/244465>