AOM events as implemented in WebKit have been deprecated https://wicg.github.io/aom/spec/input-events.html The new current proposal will be a new direction and should be handled with a different patch, if we decide to adopt it.
<rdar://problem/50027819>
Created attachment 367836 [details] patch
Created attachment 367838 [details] patch
Attachment 367838 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:2204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:570: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:571: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:574: Path does not exist. [test/expectations] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367843 [details] patch
Attachment 367843 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:570: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:571: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:574: Path does not exist. [test/expectations] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367846 [details] patch
Attachment 367846 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:570: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:571: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:574: Path does not exist. [test/expectations] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 367846 [details] patch Attachment 367846 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11936545 New failing tests: js/dom/dom-static-property-for-in-iteration.html
Created attachment 367856 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 367846 [details] patch Attachment 367846 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11937035 New failing tests: js/dom/dom-static-property-for-in-iteration.html
Created attachment 367861 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 367846 [details] patch Attachment 367846 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11937892 New failing tests: accessibility/ios-simulator/AOM-dismiss-event.html accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html
Created attachment 367873 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 367846 [details] patch Attachment 367846 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11938048 New failing tests: js/dom/dom-static-property-for-in-iteration.html
Created attachment 367874 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 367957 [details] patch
Attachment 367957 [details] did not pass style-queue: ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:570: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:571: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:572: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk1/TestExpectations:574: Path does not exist. [test/expectations] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367959 [details] patch
Comment on attachment 367959 [details] patch Attachment 367959 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11966525 New failing tests: js/dom/dom-static-property-for-in-iteration.html
Created attachment 368000 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 367959 [details] patch I think you need to rebaseline js/dom/dom-static-property-for-in-iteration.html.
Created attachment 368077 [details] Patch
Created attachment 368082 [details] patch
Attachment 368082 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:3031: Missing spaces around || [whitespace/operators] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 368083 [details] patch
Comment on attachment 368083 [details] patch Clearing flags on attachment: 368083 Committed r244582: <https://trac.webkit.org/changeset/244582>
All reviewed patches have been landed. Closing bug.