Bug 197066 - Remove useConcurrentBarriers option
Summary: Remove useConcurrentBarriers option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-18 11:52 PDT by Saam Barati
Modified: 2019-04-18 13:45 PDT (History)
14 users (show)

See Also:


Attachments
patch (3.48 KB, patch)
2019-04-18 11:55 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-04-18 11:52:22 PDT
...
Comment 1 Saam Barati 2019-04-18 11:55:36 PDT
Created attachment 367741 [details]
patch
Comment 2 Michael Saboff 2019-04-18 11:58:05 PDT
Comment on attachment 367741 [details]
patch

r=me
Comment 3 Yusuke Suzuki 2019-04-18 11:59:44 PDT
r=me too. Now, we always use FencedStoreBarrier. So I think we can drop StoreBarrier code :)
Comment 4 Yusuke Suzuki 2019-04-18 12:00:09 PDT
(In reply to Yusuke Suzuki from comment #3)
> r=me too. Now, we always use FencedStoreBarrier. So I think we can drop
> StoreBarrier code :)

Ah, no, ignore it.
Comment 5 Saam Barati 2019-04-18 12:08:48 PDT
(In reply to Yusuke Suzuki from comment #3)
> r=me too. Now, we always use FencedStoreBarrier. So I think we can drop
> StoreBarrier code :)

I originally thought that too but came to the same conclusion you did.
Comment 6 WebKit Commit Bot 2019-04-18 13:44:53 PDT
Comment on attachment 367741 [details]
patch

Clearing flags on attachment: 367741

Committed r244433: <https://trac.webkit.org/changeset/244433>
Comment 7 WebKit Commit Bot 2019-04-18 13:44:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-04-18 13:45:22 PDT
<rdar://problem/50026980>