Bug 197043 - Adopt different scroll view flashing SPI
Summary: Adopt different scroll view flashing SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-17 16:59 PDT by Tim Horton
Modified: 2019-04-17 17:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2019-04-17 16:59 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-04-17 16:59:21 PDT 
Adopt different scroll view flashing SPI
Comment 1 Tim Horton 2019-04-17 16:59:32 PDT 
Created attachment 367699 [details]
Patch
Comment 2 Tim Horton 2019-04-17 16:59:34 PDT 
<rdar://problem/49996476>
Comment 3 Geoffrey Garen 2019-04-17 17:02:44 PDT 
Comment on attachment 367699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367699&action=review

r=me

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:347
> +- (void)_flashScrollIndicatorsPersistingPreviousFlashes;

Should we #if this too?
Comment 4 Tim Horton 2019-04-17 17:03:28 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 367699 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367699&action=review
> 
> r=me
> 
> > Source/WebKit/Platform/spi/ios/UIKitSPI.h:347
> > +- (void)_flashScrollIndicatorsPersistingPreviousFlashes;
> 
> Should we #if this too?

🤷‍♂️
Comment 5 WebKit Commit Bot 2019-04-17 17:42:41 PDT 
Comment on attachment 367699 [details]
Patch

Clearing flags on attachment: 367699

Committed r244414: <https://trac.webkit.org/changeset/244414>
Comment 6 WebKit Commit Bot 2019-04-17 17:42:43 PDT 
All reviewed patches have been landed.  Closing bug.