Bug 197037 - REGRESSION (r241988): Switching tabs is slow
Summary: REGRESSION (r241988): Switching tabs is slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-17 15:37 PDT by Tim Horton
Modified: 2019-04-17 16:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.60 KB, patch)
2019-04-17 15:37 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-04-17 15:37:11 PDT 
REGRESSION (r241988): Switching tabs is slow
Comment 1 Tim Horton 2019-04-17 15:37:32 PDT 
Created attachment 367688 [details]
Patch
Comment 2 Tim Horton 2019-04-17 15:37:34 PDT 
<rdar://problem/49951473>
Comment 3 Simon Fraser (smfr) 2019-04-17 15:49:22 PDT 
Comment on attachment 367688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367688&action=review

> Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:125
> -    process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DidUpdateActivityState>(m_identifier.toUInt64(), activityStateUpdateTimeout, IPC::WaitForOption::InterruptWaitingIfSyncMessageArrives);
> +    process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DidUpdateActivityState>(m_webPageProxy.pageID(), activityStateUpdateTimeout, IPC::WaitForOption::InterruptWaitingIfSyncMessageArrives);

Type safety FTW
Comment 4 WebKit Commit Bot 2019-04-17 16:33:25 PDT 
Comment on attachment 367688 [details]
Patch

Clearing flags on attachment: 367688

Committed r244410: <https://trac.webkit.org/changeset/244410>
Comment 5 WebKit Commit Bot 2019-04-17 16:33:27 PDT 
All reviewed patches have been landed.  Closing bug.