Bug 197026 - AX: AccessibilityObject::parentObject() doesn't need to be pure virtual
Summary: AX: AccessibilityObject::parentObject() doesn't need to be pure virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-17 11:13 PDT by Devin Rousso
Modified: 2019-04-17 12:29 PDT (History)
15 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2019-04-17 11:23 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2019-04-17 11:28 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-17 11:13:18 PDT 
Rather than expect all subclasses to override `parentObject`, we can provide a stub implementation that does nothing so that we never have to worry about calling a pure virtual function (if we missed a subclass).
Comment 1 Devin Rousso 2019-04-17 11:13:32 PDT Comment hidden (obsolete)
Comment 2 Radar WebKit Bug Importer 2019-04-17 11:13:50 PDT Comment hidden (obsolete)
Comment 3 Devin Rousso 2019-04-17 11:23:15 PDT 
Created attachment 367655 [details]
Patch
Comment 4 Devin Rousso 2019-04-17 11:26:52 PDT 
<rdar://problem/49448209>
Comment 5 Devin Rousso 2019-04-17 11:28:01 PDT 
Created attachment 367656 [details]
Patch
Comment 6 WebKit Commit Bot 2019-04-17 12:29:00 PDT 
Comment on attachment 367656 [details]
Patch

Clearing flags on attachment: 367656

Committed r244394: <https://trac.webkit.org/changeset/244394>
Comment 7 WebKit Commit Bot 2019-04-17 12:29:01 PDT 
All reviewed patches have been landed.  Closing bug.