Bug 197021 – Display name is empty when getting credentials with the WebKit API.

• Status: NEW
• Component: WebKit Misc.

[Per Arne Vollan]

When getting credentials with -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:], the display name is empty.

[Radar WebKit Bug Importer]

<rdar://problem/49983718>

[Per Arne Vollan]

Created attachment 367651 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 367651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367651&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361
> +                if (!displayName)
> +                    continue;

It doesn't seem right to skip the entry just because we're missing the display name??

[Per Arne Vollan]

(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 367651 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367651&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361
> > +                if (!displayName)
> > +                    continue;
> 
> It doesn't seem right to skip the entry just because we're missing the
> display name??

That makes sense. I will update the patch. Thanks for reviewing!

[Per Arne Vollan]

Created attachment 367826 [details]
Patch