Bug 197021 - Display name is empty when getting credentials with the WebKit API.
Summary: Display name is empty when getting credentials with the WebKit API.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-17 10:55 PDT by Per Arne Vollan
Modified: 2019-04-19 14:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2019-04-17 11:01 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2019-04-19 14:21 PDT, Per Arne Vollan
pvollan: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-04-17 10:55:26 PDT
When getting credentials with -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:], the display name is empty.
Comment 1 Radar WebKit Bug Importer 2019-04-17 10:56:58 PDT
<rdar://problem/49983718>
Comment 2 Per Arne Vollan 2019-04-17 11:01:35 PDT
Created attachment 367651 [details]
Patch
Comment 3 Ryosuke Niwa 2019-04-19 12:54:28 PDT
Comment on attachment 367651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367651&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361
> +                if (!displayName)
> +                    continue;

It doesn't seem right to skip the entry just because we're missing the display name??
Comment 4 Per Arne Vollan 2019-04-19 13:57:04 PDT
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 367651 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367651&action=review
> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:361
> > +                if (!displayName)
> > +                    continue;
> 
> It doesn't seem right to skip the entry just because we're missing the
> display name??

That makes sense. I will update the patch. Thanks for reviewing!
Comment 5 Per Arne Vollan 2019-04-19 14:21:28 PDT
Created attachment 367826 [details]
Patch