RESOLVED FIXED 19702
blockquote gets clobbered on delete, but the font-tag inside it doesn't 
https://bugs.webkit.org/show_bug.cgi?id=19702
Summary blockquote gets clobbered on delete, but the font-tag inside it doesn't
Ojan Vafai
Reported 2008-06-20 18:33:54 PDT
The test-case attached has instructions. The short version is that there is a font-tag inside a blockquote. Selecting from the beginning of the font-tag to the end of the contentEditable region and hitting delete gets rid of the blockquote tag and not the font tag. It should either get rid of both or keep both. I think the right thing is to keep both. This is what IE does. It's also what MS Word does in my brief testing.
Attachments
reduced test case (413 bytes, text/html)
2008-06-20 18:34 PDT, Ojan Vafai 		no flags
Details
Adds a test (2.68 KB, patch)
2012-05-01 23:06 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Did s/ / / (12.20 KB, patch)
2012-05-01 23:09 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Right patch (2.67 KB, patch)
2012-05-02 13:12 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2008-06-20 18:34:40 PDT
Created attachment 21866 [details] reduced test case
Ryosuke Niwa
Comment 2 2012-05-01 23:06:20 PDT
Created attachment 139753 [details] Adds a test This bug appears to have been fixed. Let's just add a test.
Ryosuke Niwa
Comment 3 2012-05-01 23:08:54 PDT
Comment on attachment 139753 [details] Adds a test View in context: https://bugs.webkit.org/attachment.cgi?id=139753&action=review > LayoutTests/editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt:3 > +There should be exactly one blockquote and you should see "hello world" below: WTF... I swear I've replaced   by a space.
Ryosuke Niwa
Comment 4 2012-05-01 23:09:32 PDT
Created attachment 139754 [details] Did s/ / /
Ryosuke Niwa
Comment 5 2012-05-02 13:12:07 PDT
Created attachment 139866 [details] Right patch
Enrica Casucci
Comment 6 2012-05-02 13:13:50 PDT
Comment on attachment 139866 [details] Right patch Looks good to me.
WebKit Review Bot
Comment 7 2012-05-02 13:53:16 PDT
Comment on attachment 139866 [details] Right patch Clearing flags on attachment: 139866 Committed r115884: <http://trac.webkit.org/changeset/115884>
WebKit Review Bot
Comment 8 2012-05-02 13:53:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.