Bug 197016 - Rename "supported-color-schemes" to "color-scheme"
Summary: Rename "supported-color-schemes" to "color-scheme"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks: 193931
  Show dependency treegraph
 
Reported: 2019-04-17 09:32 PDT by Simon Fraser (smfr)
Modified: 2019-04-18 13:50 PDT (History)
8 users (show)

See Also:


Attachments
Patch (128.86 KB, patch)
2019-04-17 13:56 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (129.90 KB, patch)
2019-04-17 14:07 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.35 MB, application/zip)
2019-04-17 15:13 PDT, EWS Watchlist
no flags Details
Patch (131.82 KB, patch)
2019-04-17 15:20 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (132.55 KB, patch)
2019-04-17 15:33 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-04-17 09:32:46 PDT
The proposal at https://lilles.github.io/specs/supported-color-schemes.html is changing to that in https://github.com/w3c/csswg-drafts/issues/3807
Comment 1 Radar WebKit Bug Importer 2019-04-17 09:35:08 PDT
<rdar://problem/49980259>
Comment 2 Timothy Hatcher 2019-04-17 13:56:03 PDT Comment hidden (obsolete)
Comment 3 Simon Fraser (smfr) 2019-04-17 13:56:59 PDT Comment hidden (obsolete)
Comment 4 Timothy Hatcher 2019-04-17 14:07:45 PDT Comment hidden (obsolete)
Comment 5 Simon Fraser (smfr) 2019-04-17 14:11:35 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2019-04-17 15:13:29 PDT Comment hidden (obsolete)
Comment 7 EWS Watchlist 2019-04-17 15:13:31 PDT Comment hidden (obsolete)
Comment 8 Timothy Hatcher 2019-04-17 15:20:57 PDT Comment hidden (obsolete)
Comment 9 Timothy Hatcher 2019-04-17 15:33:09 PDT
Created attachment 367687 [details]
Patch
Comment 10 WebKit Commit Bot 2019-04-17 16:15:07 PDT
Comment on attachment 367687 [details]
Patch

Clearing flags on attachment: 367687

Committed r244408: <https://trac.webkit.org/changeset/244408>
Comment 11 WebKit Commit Bot 2019-04-17 16:15:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Ryan Haddad 2019-04-18 09:39:30 PDT
These two tests are failing on High Sierra (looks like a rebeaseline?):

css-dark-mode/older-systems/color-scheme-css.html
css-dark-mode/older-systems/color-scheme-meta.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244423%20(10736)/results.html

fast/css/style-enumerate-properties.html is failing on Windows:
https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r244423%20(2134)/results.html
Comment 13 Timothy Hatcher 2019-04-18 13:50:30 PDT
(In reply to Ryan Haddad from comment #12)
> These two tests are failing on High Sierra (looks like a rebeaseline?):
> 
> css-dark-mode/older-systems/color-scheme-css.html
> css-dark-mode/older-systems/color-scheme-meta.html
> 
> https://build.webkit.org/results/
> Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244423%20(10736)/results.
> html
> 
> fast/css/style-enumerate-properties.html is failing on Windows:
> https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> r244423%20(2134)/results.html

Fixed in https://trac.webkit.org/changeset/244430/webkit