Bug 197016 – Rename "supported-color-schemes" to "color-scheme"

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

The proposal at https://lilles.github.io/specs/supported-color-schemes.html is changing to that in https://github.com/w3c/csswg-drafts/issues/3807

[Radar WebKit Bug Importer]

<rdar://problem/49980259>

[Timothy Hatcher]

Created attachment 367675 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 367675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367675&action=review

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests: css-dark-mode/color-schemes-css.html

Some word here, please, with spec links. Please also tell me if you decided to keep support for the old name.

[Timothy Hatcher]

Created attachment 367677 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 367677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367677&action=review

> Source/WebCore/ChangeLog:22
> +        Changed `supported-color-schemes` to `color-schemes` to follow the spec changes
> +        being tracked by: https://github.com/w3c/csswg-drafts/issues/3807
> +
> +        The old `supported-color-schemes` is now an alias of `color-schemes` for compatability.

This should go above the "Tests" section.

> Source/WebCore/css/CSSProperties.json:5980
> +                "aliases": [
> +                    "supported-color-schemes"
> +                ],
> +                "converter": "ColorSchemes",

Do we have "status" text that says that it's in progress?

[EWS Watchlist]

Comment on attachment 367677 [details]
Patch

Attachment 367677 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11905969

New failing tests:
fast/css/style-enumerate-properties.html

[EWS Watchlist]

Created attachment 367684 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Timothy Hatcher]

Created attachment 367686 [details]
Patch

[Timothy Hatcher]

Created attachment 367687 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367687 [details]
Patch

Clearing flags on attachment: 367687

Committed r244408: <https://trac.webkit.org/changeset/244408>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

These two tests are failing on High Sierra (looks like a rebeaseline?):

css-dark-mode/older-systems/color-scheme-css.html
css-dark-mode/older-systems/color-scheme-meta.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244423%20(10736)/results.html

fast/css/style-enumerate-properties.html is failing on Windows:
https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r244423%20(2134)/results.html

[Timothy Hatcher]

(In reply to Ryan Haddad from comment #12)
> These two tests are failing on High Sierra (looks like a rebeaseline?):
> 
> css-dark-mode/older-systems/color-scheme-css.html
> css-dark-mode/older-systems/color-scheme-meta.html
> 
> https://build.webkit.org/results/
> Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r244423%20(10736)/results.
> html
> 
> fast/css/style-enumerate-properties.html is failing on Windows:
> https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> r244423%20(2134)/results.html

Fixed in https://trac.webkit.org/changeset/244430/webkit