Bug 197014 – [iOS] Support multiple file selection in UIDocumentPickerViewController

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Support multiple file selection in UIDocumentPickerViewController

[Andy Estes]

rdar://problem/49963514

[Andy Estes]

Created attachment 367634 [details]
Patch

[Tim Horton]

Comment on attachment 367634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367634&action=review

> Source/WebCore/en.lproj/Localizable.strings:68
> +/* label next to file upload control; parameter is the number of files when greater than one */
> +"%lu files" = "%lu files";

Why is the string up two lines not good enough? :D Or replace that one with this one? I don't know what types you need.

[Andy Estes]

Comment on attachment 367634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367634&action=review

>> Source/WebCore/en.lproj/Localizable.strings:68
>> +"%lu files" = "%lu files";
> 
> Why is the string up two lines not good enough? :D Or replace that one with this one? I don't know what types you need.

lol, will use the other one via the handy multipleFileUploadText() in LocalizedStrings.h :)

Thanks for reviewing!

[Andy Estes]

Created attachment 367669 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 367669 [details]
Patch

Clearing flags on attachment: 367669

Committed r244404: <https://trac.webkit.org/changeset/244404>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

> > Source/WebCore/en.lproj/Localizable.strings:68
> > +/* label next to file upload control; parameter is the number of files when greater than one */
> > +"%lu files" = "%lu files";
> 
> Why is the string up two lines not good enough? :D Or replace that one with
> this one? I don't know what types you need.

It actually isn't good at all!

Pluralization doesn't work like "1 vs. any other number" in many languages, see <http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html>. Foundation has proper support for this.

I checked the Russian localization in shipping WebKit for macOS, and it actually uses the hack that translators apply when software lacks full localization support - it's translated to an equivalent of "Files: %d".

[Tim Horton]

(In reply to Alexey Proskuryakov from comment #8)
> > > Source/WebCore/en.lproj/Localizable.strings:68
> > > +/* label next to file upload control; parameter is the number of files when greater than one */
> > > +"%lu files" = "%lu files";
> > 
> > Why is the string up two lines not good enough? :D Or replace that one with
> > this one? I don't know what types you need.
> 
> It actually isn't good at all!
> 
> Pluralization doesn't work like "1 vs. any other number" in many languages,
> see
> <http://www.unicode.org/cldr/charts/latest/supplemental/
> language_plural_rules.html>. Foundation has proper support for this.
> 
> I checked the Russian localization in shipping WebKit for macOS, and it
> actually uses the hack that translators apply when software lacks full
> localization support - it's translated to an equivalent of "Files: %d".

I was going to comment about this, but I don't think WebKit has a stringsdict yet? And didn't want to force bringing that up on Andy :)

[yevseytsev]

Created bug for it https://bugs.webkit.org/show_bug.cgi?id=197070

[Alexey Proskuryakov]

> I was going to comment about this, but I don't think WebKit has a
> stringsdict yet? And didn't want to force bringing that up on Andy :)

Actually it does, Source/WebCore/en.lproj/Localizable.stringsdict. Since all localization is done through WebCore, that's the one to use.