RESOLVED FIXED 197012
REGRESSION (r243926): [iOS] Release assertion when computing editor state during an overflow scroll triggered by layout
https://bugs.webkit.org/show_bug.cgi?id=197012
Summary REGRESSION (r243926): [iOS] Release assertion when computing editor state dur...
Wenson Hsieh
Reported 2019-04-17 08:13:05 PDT
Attachments
Fixes the bug (8.45 KB, patch)
2019-04-17 09:45 PDT, Wenson Hsieh
no flags
Wenson Hsieh
Comment 1 2019-04-17 09:45:34 PDT
Created attachment 367635 [details] Fixes the bug
Simon Fraser (smfr)
Comment 2 2019-04-17 10:01:34 PDT
Comment on attachment 367635 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=367635&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5295 > void WebPage::didChangeSelection() > +{ > + didChangeSelectionOrOverflowScrollPosition(EditorStateUpdateScheduling::Immediate); > +} Don't we run the risk that callers of this will trigger the same release assert?
Wenson Hsieh
Comment 3 2019-04-17 10:03:53 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 367635 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367635&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5295 > > void WebPage::didChangeSelection() > > +{ > > + didChangeSelectionOrOverflowScrollPosition(EditorStateUpdateScheduling::Immediate); > > +} > > Don't we run the risk that callers of this will trigger the same release > assert? Yes, we do; I'm hoping to remove EditorStateUpdateScheduling::Immediate altogether and always only schedule editor state updates in the (very near) future. This would also schedule rendering updates instead of scheduling compositing flushes, as it does now.
WebKit Commit Bot
Comment 4 2019-04-17 11:04:35 PDT
Comment on attachment 367635 [details] Fixes the bug Clearing flags on attachment: 367635 Committed r244388: <https://trac.webkit.org/changeset/244388>
WebKit Commit Bot
Comment 5 2019-04-17 11:04:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.