Bug 196998 – AX: HTML datalist accessibility is not exposed by WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

Test case: 
https://thepaciellogroup.github.io/AT-browser-tests/test-files/datalist.html

Spec:
https://html.spec.whatwg.org/multipage/form-elements.html#the-datalist-element

MDN:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/datalist

[Radar WebKit Bug Importer]

<rdar://problem/49962521>

[Andres Gonzalez]

Created attachment 373744 [details]
Patch

[chris fleizach]

Comment on attachment 373744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373744&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2795
> +    RefPtr<Element> element = this->element();

auto

> Source/WebCore/accessibility/AccessibilityObject.cpp:2799
> +    RefPtr<Element> datalist = element->treeScope().getElementById(datalistId);

auto

> Source/WebCore/accessibility/AccessibilityObject.cpp:2800
> +    return (datalist && is<HTMLDataListElement>(datalist));

the datalist pointer check seems like it might not necessary since is<HTMLDataListElement> should handle the null

[EWS Watchlist]

Comment on attachment 373744 [details]
Patch

Attachment 373744 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12700457

New failing tests:
accessibility/datalist.html

[EWS Watchlist]

Created attachment 373750 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373744 [details]
Patch

Attachment 373744 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12700741

New failing tests:
accessibility/datalist.html

[EWS Watchlist]

Created attachment 373766 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Andres Gonzalez]

Created attachment 373767 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #3)
> Comment on attachment 373744 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373744&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2795
> > +    RefPtr<Element> element = this->element();
> 
> auto
>
Thought that RefPtr does some referencing counting on the pointer it holds and thus it would be better to type it explicitly. Never know what these functions that return a naked pointer are doing behind the scene.

> > Source/WebCore/accessibility/AccessibilityObject.cpp:2799
> > +    RefPtr<Element> datalist = element->treeScope().getElementById(datalistId);
> 
> auto
> 
Changed this one to auto but feel that is an example of auto abuse since it is harder to figure out the type of datalist from the initialization on the right hand side than actually typing the variable explicitly.

> > Source/WebCore/accessibility/AccessibilityObject.cpp:2800
> > +    return (datalist && is<HTMLDataListElement>(datalist));
> 
> the datalist pointer check seems like it might not necessary since
> is<HTMLDataListElement> should handle the null

Done.

[Andres Gonzalez]

Created attachment 373793 [details]
Patch

[Andres Gonzalez]

#if for datalist feature availability.

[chris fleizach]

Comment on attachment 373793 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373793&action=review

> LayoutTests/ChangeLog:9
> +        * accessibility/datalist-expected.txt: Added.

will probably need TestExpectation changes to platforms not supporting datalist

also I suspect that other platforms have not implemented popupValue for WKTR and DRT so this test will probably fail on that (GTK)

[EWS Watchlist]

Comment on attachment 373793 [details]
Patch

Attachment 373793 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12703171

New failing tests:
accessibility/datalist.html

[EWS Watchlist]

Created attachment 373799 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 373793 [details]
Patch

Attachment 373793 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12703320

New failing tests:
accessibility/datalist.html

[EWS Watchlist]

Created attachment 373807 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Andres Gonzalez]

Created attachment 373810 [details]
Patch

[Andres Gonzalez]

Updated TestExpectations for platforms that have no support for datalist.

[WebKit Commit Bot]

Comment on attachment 373810 [details]
Patch

Clearing flags on attachment: 373810

Committed r247295: <https://trac.webkit.org/changeset/247295>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.