RESOLVED FIXED 196992
Remember device orientation permission for the duration of the browsing session 
https://bugs.webkit.org/show_bug.cgi?id=196992
Summary Remember device orientation permission for the duration of the browsing session
Chris Dumez
Reported 2019-04-16 15:50:14 PDT
Remember device orientation permission for the duration of the browsing session.
Attachments
Patch (47.51 KB, patch)
2019-04-16 16:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (48.44 KB, patch)
2019-04-16 16:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (55.77 KB, patch)
2019-04-16 16:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.92 MB, application/zip)
2019-04-16 19:25 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (9.84 MB, application/zip)
2019-04-16 22:01 PDT, EWS Watchlist 		no flags
Details
Patch (60.04 KB, patch)
2019-04-17 08:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-04-16 15:50:26 PDT
<rdar://problem/49946067>
Chris Dumez
Comment 2 2019-04-16 16:00:02 PDT
Created attachment 367587 [details] Patch
EWS Watchlist
Comment 3 2019-04-16 16:02:27 PDT
Attachment 367587 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2019-04-16 16:24:54 PDT
Created attachment 367593 [details] Patch
EWS Watchlist
Comment 5 2019-04-16 16:27:39 PDT
Attachment 367593 [details] did not pass style-queue: ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 6 2019-04-16 16:54:13 PDT
Created attachment 367594 [details] Patch
EWS Watchlist
Comment 7 2019-04-16 16:56:54 PDT
Attachment 367594 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:170: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 8 2019-04-16 19:25:13 PDT
Comment on attachment 367594 [details] Patch Attachment 367594 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11893581 New failing tests: storage/indexeddb/modern/gc-closes-database.html
EWS Watchlist
Comment 9 2019-04-16 19:25:24 PDT
Created attachment 367599 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
EWS Watchlist
Comment 10 2019-04-16 22:01:45 PDT
Comment on attachment 367594 [details] Patch Attachment 367594 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11895275 New failing tests: fast/device-orientation/device-motion-request-permission-granted.html fast/device-orientation/device-orientation-request-permission-user-gesture.html fast/device-orientation/device-motion-request-permission-user-gesture.html
EWS Watchlist
Comment 11 2019-04-16 22:01:47 PDT
Created attachment 367608 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Chris Dumez
Comment 12 2019-04-17 08:44:05 PDT
Created attachment 367628 [details] Patch
EWS Watchlist
Comment 13 2019-04-17 08:46:08 PDT
Attachment 367628 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:170: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/ChromeClient.h:489: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 14 2019-04-17 09:16:51 PDT
Comment on attachment 367628 [details] Patch r=me
WebKit Commit Bot
Comment 15 2019-04-17 10:04:06 PDT
Comment on attachment 367628 [details] Patch Clearing flags on attachment: 367628 Committed r244382: <https://trac.webkit.org/changeset/244382>
WebKit Commit Bot
Comment 16 2019-04-17 10:04:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.