Link clicks in PDFs shouldn't send referrer headers This is a good harden that matches other browsers.
Created attachment 367560 [details] Patch
Created attachment 367563 [details] Patch
Comment on attachment 367563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367563&action=review > LayoutTests/http/tests/security/pdf-referrer.html:4 > +if (window.testRunner) { Please make it more clear how this checks for the referrer > LayoutTests/http/tests/security/pdf-referrer.html:13 > + testRunner.notifyDone(); weird extra tab
Comment on attachment 367563 [details] Patch Attachment 367563 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11889925 New failing tests: http/tests/security/pdf-referrer.html
Created attachment 367575 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
This layout test is a PITA. Working on an API test instead.
Comment on attachment 367563 [details] Patch Attachment 367563 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11890539 New failing tests: http/tests/security/pdf-referrer.html
Created attachment 367585 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 367563 [details] Patch Attachment 367563 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11890702 New failing tests: http/tests/security/pdf-referrer.html
Created attachment 367586 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 367563 [details] Patch Attachment 367563 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11895605 New failing tests: http/tests/security/pdf-referrer.html
Created attachment 367612 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 367658 [details] Patch
Layout test ❌ API test ✅
Attachment 367658 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 367661 [details] Patch
Comment on attachment 367661 [details] Patch Attachment 367661 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11904331 New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-abort.https.html
Created attachment 367673 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #18) > Created attachment 367673 [details] > Archive of layout-test-results from ews121 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6 Those failures definitely not from this patch.
Comment on attachment 367661 [details] Patch Clearing flags on attachment: 367661 Committed r244405: <https://trac.webkit.org/changeset/244405>
All reviewed patches have been landed. Closing bug.
<rdar://problem/49995849>