WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
196980
Link clicks in PDFs shouldn't send referrer headers
https://bugs.webkit.org/show_bug.cgi?id=196980
Summary
Link clicks in PDFs shouldn't send referrer headers
Brady Eidson
Reported
2019-04-16 13:36:25 PDT
Link clicks in PDFs shouldn't send referrer headers This is a good harden that matches other browsers.
Attachments
Patch
(18.12 KB, patch)
2019-04-16 13:41 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Patch
(20.12 KB, patch)
2019-04-16 13:50 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-highsierra
(3.08 MB, application/zip)
2019-04-16 14:42 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2
(9.92 MB, application/zip)
2019-04-16 15:53 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews202 for win-future
(12.95 MB, application/zip)
2019-04-16 15:53 PDT
,
EWS Watchlist
no flags
Details
Archive of layout-test-results from ews112 for mac-highsierra
(3.14 MB, application/zip)
2019-04-16 22:30 PDT
,
EWS Watchlist
no flags
Details
Patch
(18.19 KB, patch)
2019-04-17 11:32 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Patch
(16.78 KB, patch)
2019-04-17 12:14 PDT
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2
(3.18 MB, application/zip)
2019-04-17 13:52 PDT
,
EWS Watchlist
no flags
Details
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2019-04-16 13:41:32 PDT
Created
attachment 367560
[details]
Patch
Brady Eidson
Comment 2
2019-04-16 13:50:40 PDT
Created
attachment 367563
[details]
Patch
Tim Horton
Comment 3
2019-04-16 13:58:18 PDT
Comment on
attachment 367563
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=367563&action=review
> LayoutTests/http/tests/security/pdf-referrer.html:4 > +if (window.testRunner) {
Please make it more clear how this checks for the referrer
> LayoutTests/http/tests/security/pdf-referrer.html:13 > + testRunner.notifyDone();
weird extra tab
EWS Watchlist
Comment 4
2019-04-16 14:42:38 PDT
Comment on
attachment 367563
[details]
Patch
Attachment 367563
[details]
did not pass mac-ews (mac): Output:
https://webkit-queues.webkit.org/results/11889925
New failing tests: http/tests/security/pdf-referrer.html
EWS Watchlist
Comment 5
2019-04-16 14:42:40 PDT
Created
attachment 367575
[details]
Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Brady Eidson
Comment 6
2019-04-16 15:28:50 PDT
This layout test is a PITA. Working on an API test instead.
EWS Watchlist
Comment 7
2019-04-16 15:53:03 PDT
Comment on
attachment 367563
[details]
Patch
Attachment 367563
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/11890539
New failing tests: http/tests/security/pdf-referrer.html
EWS Watchlist
Comment 8
2019-04-16 15:53:05 PDT
Created
attachment 367585
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 9
2019-04-16 15:53:11 PDT
Comment on
attachment 367563
[details]
Patch
Attachment 367563
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/11890702
New failing tests: http/tests/security/pdf-referrer.html
EWS Watchlist
Comment 10
2019-04-16 15:53:23 PDT
Created
attachment 367586
[details]
Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
EWS Watchlist
Comment 11
2019-04-16 22:30:21 PDT
Comment on
attachment 367563
[details]
Patch
Attachment 367563
[details]
did not pass mac-debug-ews (mac): Output:
https://webkit-queues.webkit.org/results/11895605
New failing tests: http/tests/security/pdf-referrer.html
EWS Watchlist
Comment 12
2019-04-16 22:30:23 PDT
Created
attachment 367612
[details]
Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Brady Eidson
Comment 13
2019-04-17 11:32:32 PDT
Created
attachment 367658
[details]
Patch
Brady Eidson
Comment 14
2019-04-17 11:33:52 PDT
Layout test ❌ API test ✅
EWS Watchlist
Comment 15
2019-04-17 11:35:49 PDT
Attachment 367658
[details]
did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 16
2019-04-17 12:14:57 PDT
Created
attachment 367661
[details]
Patch
EWS Watchlist
Comment 17
2019-04-17 13:52:35 PDT
Comment on
attachment 367661
[details]
Patch
Attachment 367661
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/11904331
New failing tests: imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-abort.https.html
EWS Watchlist
Comment 18
2019-04-17 13:52:37 PDT
Created
attachment 367673
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Brady Eidson
Comment 19
2019-04-17 15:42:09 PDT
(In reply to Build Bot from
comment #18
)
> Created
attachment 367673
[details]
> Archive of layout-test-results from ews121 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Those failures definitely not from this patch.
WebKit Commit Bot
Comment 20
2019-04-17 15:47:14 PDT
Comment on
attachment 367661
[details]
Patch Clearing flags on attachment: 367661 Committed
r244405
: <
https://trac.webkit.org/changeset/244405
>
WebKit Commit Bot
Comment 21
2019-04-17 15:47:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 22
2019-04-17 15:48:39 PDT
<
rdar://problem/49995849
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug