Bug 19696 - Memory leak in WebCore/editing/DeleteButtonController.cpp
Summary: Memory leak in WebCore/editing/DeleteButtonController.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-20 14:34 PDT by Rahul Kuchhal
Modified: 2008-06-22 17:52 PDT (History)
0 users

See Also:

Attachments
Patch for the bug (648 bytes, patch)
2008-06-20 14:44 PDT, Rahul Kuchhal 		no flags Details | Formatted Diff | Diff
Patch (1.13 KB, patch)
2008-06-20 15:18 PDT, Rahul Kuchhal 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rahul Kuchhal 2008-06-20 14:34:08 PDT 
Purify reports a memory leak at:

 webkit/webcore/editing/deletebuttoncontroller.cpp:198  WebCore::DeleteButtonController::createDeletionUI(void)
 webkit/webcore/editing/deletebuttoncontroller.cpp:230  WebCore::DeleteButtonController::show(HTMLElement::WebCore *)
 webkit/webcore/editing/deletebuttoncontroller.cpp:138  WebCore::DeleteButtonController::respondToChangedSelection(Selection::WebCore const&)
 webkit/webcore/editing/editor.cpp:396  WebCore::Editor::respondToChangedSelection(Selection::WebCore const&)
Comment 1 Rahul Kuchhal 2008-06-20 14:44:00 PDT 
Created attachment 21860 [details]
Patch for the bug
Comment 2 Rahul Kuchhal 2008-06-20 15:18:41 PDT 
Created attachment 21862 [details]
Patch
Comment 3 Darin Adler 2008-06-20 15:53:29 PDT 
Comment on attachment 21862 [details]
Patch

r=me
Comment 4 Mark Rowe (bdash) 2008-06-22 17:51:35 PDT 
As per my comment in bug 19697, please take care when creating the ChangeLog entry.
Comment 5 Mark Rowe (bdash) 2008-06-22 17:52:14 PDT 
Landed in r34730.