Bug 19695 - webkit_web_view_get_settings clashes with gtk_widget_get_settings
Summary: webkit_web_view_get_settings clashes with gtk_widget_get_settings
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-06-20 13:02 PDT by Christian Dywan
Modified: 2017-03-11 11:01 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2008-06-20 13:02:24 PDT 
webkit_web_view_get_settings clashes with gtk_widget_get_settings.

This is not necessarily a problem in the C interface, however it might be confusing and more importantly in bindings that map something like foo.getSettings or foo.get_settings.

I suggest to rename the accessor and property to actually refer to web_settings instead of settings.
Comment 1 Martin Robinson 2012-02-20 14:31:12 PST 
Carlos, here's another bindings issue that we should figure out how to fix for WebKit.
Comment 2 Carlos Garcia Campos 2012-02-20 23:36:54 PST 
webkit_web_view_get_web_settings() makes sense in WebKit1 where settings object is WebKitWebSettings, but in WebKit2 is WebKitSettings. Don't have bindings a way to deal with this?