RESOLVED FIXED196949
Stop using hyphenationFactor 
https://bugs.webkit.org/show_bug.cgi?id=196949
Summary Stop using hyphenationFactor
Alex Christensen
Reported 2019-04-15 17:19:36 PDT
Stop using hyphenationFactor
Attachments
Patch (1.36 KB, patch)
2019-04-15 17:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-04-15 17:21:25 PDT
Created attachment 367479 [details] Patch
Alex Christensen
Comment 2 2019-04-15 17:21:27 PDT
<rdar://problem/49779594>
Geoffrey Garen
Comment 3 2019-04-15 17:25:04 PDT
Comment on attachment 367479 [details] Patch r=me How did you test the visual result? Is this covered by regression tests?
Alex Christensen
Comment 4 2019-04-15 18:15:49 PDT
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 367479 [details] > Patch > > r=me > > How did you test the visual result? I tested that the visual result was good without this call when working on r241124. I actually saw no effect when adding this, and I considered it unnecessary but added it anyway based on feedback from you and out of abundance of caution. > Is this covered by regression tests? No.
WebKit Commit Bot
Comment 5 2019-04-15 18:43:35 PDT
Comment on attachment 367479 [details] Patch Clearing flags on attachment: 367479 Committed r244319: <https://trac.webkit.org/changeset/244319>
WebKit Commit Bot
Comment 6 2019-04-15 18:43:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.