Bug 196949 - Stop using hyphenationFactor
Summary: Stop using hyphenationFactor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-15 17:19 PDT by Alex Christensen
Modified: 2019-04-15 18:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2019-04-15 17:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-15 17:19:36 PDT 
Stop using hyphenationFactor
Comment 1 Alex Christensen 2019-04-15 17:21:25 PDT 
Created attachment 367479 [details]
Patch
Comment 2 Alex Christensen 2019-04-15 17:21:27 PDT 
<rdar://problem/49779594>
Comment 3 Geoffrey Garen 2019-04-15 17:25:04 PDT 
Comment on attachment 367479 [details]
Patch

r=me

How did you test the visual result? Is this covered by regression tests?
Comment 4 Alex Christensen 2019-04-15 18:15:49 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 367479 [details]
> Patch
> 
> r=me
> 
> How did you test the visual result? 
I tested that the visual result was good without this call when working on r241124.  I actually saw no effect when adding this, and I considered it unnecessary but added it anyway based on feedback from you and out of abundance of caution. 
> Is this covered by regression tests?
No.
Comment 5 WebKit Commit Bot 2019-04-15 18:43:35 PDT 
Comment on attachment 367479 [details]
Patch

Clearing flags on attachment: 367479

Committed r244319: <https://trac.webkit.org/changeset/244319>
Comment 6 WebKit Commit Bot 2019-04-15 18:43:37 PDT 
All reviewed patches have been landed.  Closing bug.