Bug 196941 – URL set by document.open() is not communicated to the UIProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

URL set by document.open() is not communicated to the UIProcess and thus not reflected via WKWebView.URL.

[Chris Dumez]

<rdar://problem/49237544>

[Chris Dumez]

Created attachment 367466 [details]
Patch

[EWS Watchlist]

Attachment 367466 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/FrameLoaderClient.h:184:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 367466 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 367466 [details]
Patch

Clearing flags on attachment: 367466

Committed r244321: <https://trac.webkit.org/changeset/244321>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shawn Roberts]

After changes in https://trac.webkit.org/changeset/244321 

Mac WK2 Debug queues are exiting early after 50 crashes.

https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/2315

ASSERTION FAILED: m_uncommittedState.state == State::Committed
/Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/PageLoadState.cpp(307) : void WebKit::PageLoadState::didFinishLoad(const Transaction::Token &)
1   0x10406ada9 WTFCrash
2   0x10d125b5b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x10d9fbb4d WebKit::PageLoadState::didFinishLoad(WebKit::PageLoadState::Transaction::Token const&)
4   0x10dbb8ff2 WebKit::WebPageProxy::didFinishLoadForFrame(unsigned long long, unsigned long long, WebKit::UserData const&)

https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r244328%20(2319)/dom/html/level1/core/documentinvalidcharacterexceptioncreatepi1-crash-log.txt

[Shawn Roberts]

Looks like it's affecting all WK2 Debug builds. iOS Simulator and High Sierra are also exiting early or timing out.

https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/7458

https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29/builds/3308

[WebKit Commit Bot]

Re-opened since this is blocked by bug 196968

[Chris Dumez]

Created attachment 367564 [details]
Patch

[EWS Watchlist]

Attachment 367564 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/FrameLoaderClient.h:184:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 367564 [details]
Patch

Rejecting attachment 367564 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 367564, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11890540

[Chris Dumez]

Created attachment 367589 [details]
Patch

[Chris Dumez]

Comment on attachment 367589 [details]
Patch

Clearing flags on attachment: 367589

Committed r244361: <https://trac.webkit.org/changeset/244361>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.